Improve variable detection in checkvariables.php #316
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also detects %s or %S.
pro: you can find more errors (example for cs).
neg: more false positives. Code now reports a mismatch between %S and %s, and %S and %1$S, and both are correct. The alternative is to put more logic in the class
This now matches only "brandshortname" in "test brandshortname.". Negative lookbehind is used to avoid some false positive, example
My%1$SFeeds-%2$S.opml
.