Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve check variables controls, switch to MVC #446

Merged
merged 1 commit into from Apr 9, 2015

Conversation

@flodolo
Copy link
Contributor

@flodolo flodolo commented Apr 4, 2015

  • We need l10njs checks also in browser (for PDFViewer and Loop)
  • l10njs: _ is a valid character for a variable name
  • l10njs: ignore white spaces ({{n}} == {{ n }})
  • printf: discovered that %s is not the same as %S: https://bugzilla.mozilla.org/show_bug.cgi?id=1133554
  • Use regular expression to check translations. Example: en-US has "$name", translation has "$nameDA", error is not reported with strpos.

Switched view to MVC and added component filter to view.

@flodolo
Copy link
Contributor Author

@flodolo flodolo commented Apr 4, 2015

This fixes #337, which is not really an easy pick.

Loading

@flodolo
Copy link
Contributor Author

@flodolo flodolo commented Apr 5, 2015

Using this PR to switch to MCV too, so WIP for now (we need a tag for that).

Loading

@flodolo flodolo changed the title Improve check variables view Improve check variables controls, switch to MVC Apr 5, 2015
@flodolo
Copy link
Contributor Author

@flodolo flodolo commented Apr 5, 2015

This is really weird. I pushed several times to my branch, but it's not reflected in this PR 🎱

Loading

@flodolo
Copy link
Contributor Author

@flodolo flodolo commented Apr 5, 2015

Got a reply from Github support (that was fast, especially on Easter morning!). It's an issue on their side, they're working on it.

Loading

Switched view to MVC and added component filter to view.

Checks improvements:
* We need l10njs checks also in browser (for PDFViewer and Loop)
* l10njs: _ is a valid character for a variable name
* l10njs: ignore white spaces ({{n}} == {{ n }})
* printf: discovered that %s is not the same as %S: https://bugzilla.mozilla.org/show_bug.cgi?id=1133554
* Use regular expression to check translations. Example: en-US has "$name", translation has "$nameDA", error is not reported with strpos.
@flodolo
Copy link
Contributor Author

@flodolo flodolo commented Apr 5, 2015

OK, PR updated, ready to test and review.

Loading

@pascalchevrel
Copy link
Member

@pascalchevrel pascalchevrel commented Apr 9, 2015

Works well, LGTM

Loading

pascalchevrel added a commit that referenced this issue Apr 9, 2015
 Improve check variables controls, switch to MVC
@pascalchevrel pascalchevrel merged commit 9bb8d93 into mozfr:master Apr 9, 2015
1 check passed
Loading
@flodolo flodolo deleted the checkvar branch Apr 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants