Improve check variables controls, switch to MVC #446

Merged
merged 1 commit into from Apr 9, 2015

Conversation

Projects
None yet
2 participants
@flodolo
Contributor

flodolo commented Apr 4, 2015

  • We need l10njs checks also in browser (for PDFViewer and Loop)
  • l10njs: _ is a valid character for a variable name
  • l10njs: ignore white spaces ({{n}} == {{ n }})
  • printf: discovered that %s is not the same as %S: https://bugzilla.mozilla.org/show_bug.cgi?id=1133554
  • Use regular expression to check translations. Example: en-US has "$name", translation has "$nameDA", error is not reported with strpos.

Switched view to MVC and added component filter to view.

@flodolo

This comment has been minimized.

Show comment
Hide comment
@flodolo

flodolo Apr 4, 2015

Contributor

This fixes #337, which is not really an easy pick.

Contributor

flodolo commented Apr 4, 2015

This fixes #337, which is not really an easy pick.

@flodolo

This comment has been minimized.

Show comment
Hide comment
@flodolo

flodolo Apr 5, 2015

Contributor

Using this PR to switch to MCV too, so WIP for now (we need a tag for that).

Contributor

flodolo commented Apr 5, 2015

Using this PR to switch to MCV too, so WIP for now (we need a tag for that).

@flodolo flodolo changed the title from Improve check variables view to Improve check variables controls, switch to MVC Apr 5, 2015

@flodolo

This comment has been minimized.

Show comment
Hide comment
@flodolo

flodolo Apr 5, 2015

Contributor

This is really weird. I pushed several times to my branch, but it's not reflected in this PR 🎱

Contributor

flodolo commented Apr 5, 2015

This is really weird. I pushed several times to my branch, but it's not reflected in this PR 🎱

@flodolo

This comment has been minimized.

Show comment
Hide comment
@flodolo

flodolo Apr 5, 2015

Contributor

Got a reply from Github support (that was fast, especially on Easter morning!). It's an issue on their side, they're working on it.

Contributor

flodolo commented Apr 5, 2015

Got a reply from Github support (that was fast, especially on Easter morning!). It's an issue on their side, they're working on it.

Improve check variables controls, switch to MVC
Switched view to MVC and added component filter to view.

Checks improvements:
* We need l10njs checks also in browser (for PDFViewer and Loop)
* l10njs: _ is a valid character for a variable name
* l10njs: ignore white spaces ({{n}} == {{ n }})
* printf: discovered that %s is not the same as %S: https://bugzilla.mozilla.org/show_bug.cgi?id=1133554
* Use regular expression to check translations. Example: en-US has "$name", translation has "$nameDA", error is not reported with strpos.
@flodolo

This comment has been minimized.

Show comment
Hide comment
@flodolo

flodolo Apr 5, 2015

Contributor

OK, PR updated, ready to test and review.

Contributor

flodolo commented Apr 5, 2015

OK, PR updated, ready to test and review.

@pascalchevrel

This comment has been minimized.

Show comment
Hide comment
@pascalchevrel

pascalchevrel Apr 9, 2015

Member

Works well, LGTM

Member

pascalchevrel commented Apr 9, 2015

Works well, LGTM

pascalchevrel added a commit that referenced this pull request Apr 9, 2015

Merge pull request #446 from flodolo/checkvar
 Improve check variables controls, switch to MVC

@pascalchevrel pascalchevrel merged commit 9bb8d93 into mozfr:master Apr 9, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@flodolo flodolo deleted the flodolo:checkvar branch Apr 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment