Fix issue #610 #615
Merged
Fix issue #610 #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,6 @@ | |||
| <?php | |||
| namespace Transvision; | |||
| use Zend\Json\Json; | |||
MatonAnthony
force-pushed
the
patch-issue-610
branch
from
91b5e71
to
8039046
Compare
| @@ -78,7 +80,8 @@ public static function getSupportedRepositories() | |||
| // Read list of repositories from supported_repositories.json | |||
| $file_name = APP_SOURCES . 'supported_repositories.json'; | |||
| if (file_exists($file_name)) { | |||
| $json_repositories = json_decode(file_get_contents($file_name), true); | |||
| $json_repositories = new Json($file_name); | |||
| $json_repositories = $json_repositories->fetchContent(); | |||
There was a problem hiding this comment.
You can do that in one line which remains easy to read:
$json_repositories = (new Json($file_name))->fetchContent();
MatonAnthony
force-pushed
the
patch-issue-610
branch
from
8039046
to
c9044cf
Compare
|
Fixed |
flodolo
added a commit
that referenced
this pull request
Feb 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the mozillal10n JSON class instead of json_encode()
Fix issue #610