Use two columns for QA views #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @pascalchevrel, @tx2z and @TheoChevalier to be potential reviewers |
|
The failure is a Travis bug |
|
It works well, I might have gone the road of using real css columns instead of floats (https://developer.mozilla.org/fr/docs/Web/CSS/columns) but this version is good for me 👍 |
|
I don't think you can have columns with different widths? You could create 4 columns, but then you couldn't center the "QA views" title, and if you move the titles "out" of the columns you'll have issues with smaller viewports (title are not preceding their links). |
|
Waiting for Travis to re-run, then I'll merge. If we remove the "logo", we can also recover some space at the top of the container. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #663, it should be good for a test run.
Tested with Chrome and Firefox, it seems to work without particular issue. I decided to go vertical on the smaller viewport though, I think the text would be too small with 2 columns.