Improve a11y and make results easier to read #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results look definitely more readable to me, also no issue in using px. I'll take a look at the ESLint failure later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the feedback received over the last couple days.
Fira Sans Regular is too bold, Fira Sans Light is hard to read for some people, let’s try with Fira Sans Book. We’re running out of alternative weight, so this better be the good one ;) I think it’s very similar to what we have on prod. I also hardcoded the font-size in pixels, 0.9em makes it ~12.96px, and 13px seem to looks better (tried on a non hi-DPI screen)