Fix config export for positional arguments #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored exportRuntimeArgs to properly handle positional arguments that were previously being skipped. Split logic into clean helper functions following functional programming principles. - Add partitionArgs() to separate positional and flag arguments - Add exportPositionalArgs() to handle ARG_1, ARG_2, etc. - Add exportFlagArgs() for flag argument processing - Add comprehensive test coverage for all scenarios
peteski22
force-pushed
the
peteski22/cmd/fix-export-pos-args
branch
from
2492281 to
c5174cf
Compare
peteski22
changed the title
dpoulopoulos
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a config export bug: Positional arguments were being silently skipped during
mcpd config exportThe
exportRuntimeArgsfunction was skipping all positional (non-flag) arguments with a continue statement, causing them to be missing from exported environment files.