Gecko incremental update tools #170

merged 2 commits into from Nov 14, 2012


None yet

2 participants

@marshall marshall referenced this pull request in mozilla-b2g/gonk-misc Nov 13, 2012

Initial build support for incremental gecko (OTA) updates #54


nit: the or portion is redundant? A zero length string returns false in an if statement, so it will never evaluate the or portion


nit: This loop "feels" odd to me

for i in range(len(self.CONFIG_VARS)):
setattr(self, self.CONFIG_VARS[i], lines[i].strip())

feels like a more natural way to write this

Mozilla-B2G member

r=me with nits addressed or appropriate counter arguments made :)

@marshall marshall merged commit fbee236 into mozilla-b2g:master Nov 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment