This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1084041 - Remove files after applying FOTA r=gsvelto #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not have any leftover files after applying a FOTA package update, so we should ensure we are removing them at the end of the process: - MAR package that has been extracted to /data/local/... - update.zip that has been extracted to the sdcard for applying in recovery mode
| @@ -46,6 +46,8 @@ def build_flash_fota(args): | |||
| builder.fota_dirs = args.fota_dirs.split(' ') | |||
| builder.fota_files = [line.rstrip() for line in open(args.fota_files, 'r')] | |||
|
|
|||
| builder.fota_sdcard = args.fota_sdcard or "/sdcard" | |||
There was a problem hiding this comment.
nit: Do you really need this? You're already setting /sdcard as the default path in the add_argument() call below
There was a problem hiding this comment.
Yes, I've seen some devices where the device tree configuration may be wrong, so this is not 100% required, but it makes sure we won't generate improper paths.
There was a problem hiding this comment.
OK, let's leave it in then.
lissyx
added a commit
that referenced
this pull request
Jan 7, 2015
Bug 1084041 - Remove files after applying FOTA r=gsvelto
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not have any leftover files after applying a FOTA package
update, so we should ensure we are removing them at the end of the
process:
recovery mode