OS X 10.8 compatibility etc. #52

Merged
merged 0 commits into from Jul 19, 2012

Conversation

Projects
None yet
3 participants
@a2sheppy
Contributor

a2sheppy commented Jun 28, 2012

Update to handle OS X 10.8, be more intelligent about finding Xcode, prompt the user to install Java if it's not installed (since some of the android stuff requires it), and add information about what to do once Xcode is installed.

scripts/bootstrap-mac.sh
-
+
+ java_ver=`java -version`
+ echo "$java_ver"

This comment has been minimized.

@marshall

marshall Jul 1, 2012

Contributor

Looks like this might be left over debugging code..

@marshall

marshall Jul 1, 2012

Contributor

Looks like this might be left over debugging code..

This comment has been minimized.

@a2sheppy

a2sheppy Jul 1, 2012

Contributor

Nope. This triggers the install of Java if you don't already have it, and displays the Java version (or "prompting to install Java" if it needs installing).

Eric Shepherd
Sent from my iPad

On Jul 1, 2012, at 1:25 PM, Marshall Culpepper reply@reply.github.com wrote:

Looks like this might be left over debugging code..

@a2sheppy

a2sheppy Jul 1, 2012

Contributor

Nope. This triggers the install of Java if you don't already have it, and displays the Java version (or "prompting to install Java" if it needs installing).

Eric Shepherd
Sent from my iPad

On Jul 1, 2012, at 1:25 PM, Marshall Culpepper reply@reply.github.com wrote:

Looks like this might be left over debugging code..

This comment has been minimized.

@michaelwu

michaelwu Jul 12, 2012

Contributor

Please remove this. We do not use java in the build, despite any messages that may complain about it.

@michaelwu

michaelwu Jul 12, 2012

Contributor

Please remove this. We do not use java in the build, despite any messages that may complain about it.

scripts/bootstrap-mac.sh
+ echo " 2. If it asks for permission to update the command line tools, let it."
+ echo " 3. If it doesn't, open the Preferences, go to the Downloads panel, and install them."
+ echo ""
+ echo "Then run this script again to continue configuring to build Boot2Gecko."

This comment has been minimized.

@marshall

marshall Jul 1, 2012

Contributor

Hrm, were these steps necessary in Lion / Snow Leopard as well, or just Mountain Lion?

@marshall

marshall Jul 1, 2012

Contributor

Hrm, were these steps necessary in Lion / Snow Leopard as well, or just Mountain Lion?

This comment has been minimized.

@a2sheppy

a2sheppy Jul 1, 2012

Contributor

All Xcode 4 and later. Could skip the stuff about installing the command line tools on Xcode 3.

Eric Shepherd
Sent from my iPad

On Jul 1, 2012, at 1:29 PM, Marshall Culpepper reply@reply.github.com wrote:

  • else
  •  echo "You will need to install \"Xcode 3.2.6 for Snow Leopard\" to build Boot2Gecko."
    
  •  echo "Note: This is a 4.1GB download, and requires a free Apple account."
    
  •  echo ""
    
  •  prompt_question "Do you want to download XCode 3.2.6 for Snow Leopard in your browser? [Y/n] " Y
    
  •  if [[ $answer = Y ]]; then
    
  •      run_command open https://developer.apple.com/downloads/download.action\?path=Developer_Tools/xcode_3.2.6_and_ios_sdk_4.3__final/xcode_3.2.6_and_ios_sdk_4.3.dmg
    
  •  fi
    
  • fi
  • echo ""
  • echo "After installing Xcode, follow these steps:"
  • echo " 1. Run Xcode to allow it to configure itself."
  • echo " 2. If it asks for permission to update the command line tools, let it."
  • echo " 3. If it doesn't, open the Preferences, go to the Downloads panel, and install them."
  • echo ""
  • echo "Then run this script again to continue configuring to build Boot2Gecko."

Hrm, were these steps necessary in Lion / Snow Leopard as well, or just Mountain Lion?


Reply to this email directly or view it on GitHub:
https://github.com/mozilla-b2g/B2G/pull/52/files#r1081899

@a2sheppy

a2sheppy Jul 1, 2012

Contributor

All Xcode 4 and later. Could skip the stuff about installing the command line tools on Xcode 3.

Eric Shepherd
Sent from my iPad

On Jul 1, 2012, at 1:29 PM, Marshall Culpepper reply@reply.github.com wrote:

  • else
  •  echo "You will need to install \"Xcode 3.2.6 for Snow Leopard\" to build Boot2Gecko."
    
  •  echo "Note: This is a 4.1GB download, and requires a free Apple account."
    
  •  echo ""
    
  •  prompt_question "Do you want to download XCode 3.2.6 for Snow Leopard in your browser? [Y/n] " Y
    
  •  if [[ $answer = Y ]]; then
    
  •      run_command open https://developer.apple.com/downloads/download.action\?path=Developer_Tools/xcode_3.2.6_and_ios_sdk_4.3__final/xcode_3.2.6_and_ios_sdk_4.3.dmg
    
  •  fi
    
  • fi
  • echo ""
  • echo "After installing Xcode, follow these steps:"
  • echo " 1. Run Xcode to allow it to configure itself."
  • echo " 2. If it asks for permission to update the command line tools, let it."
  • echo " 3. If it doesn't, open the Preferences, go to the Downloads panel, and install them."
  • echo ""
  • echo "Then run this script again to continue configuring to build Boot2Gecko."

Hrm, were these steps necessary in Lion / Snow Leopard as well, or just Mountain Lion?


Reply to this email directly or view it on GitHub:
https://github.com/mozilla-b2g/B2G/pull/52/files#r1081899

scripts/bootstrap-mac.sh
+
+ # Peel the OS X SDK version out of the path so we don't have to mess with it
+ # by hand; courtesy Geoff Weiss
+ if [[ $osx_sdk =~ MacOSX([0-9]+.[0-9]+).sdk ]]; then

This comment has been minimized.

@marshall

marshall Jul 2, 2012

Contributor

Nit: the two . here will match any character (not just the literal .), you can fix that by escaping them:

MacOSX([0-9]+\.[0-9]+)\.sdk

@marshall

marshall Jul 2, 2012

Contributor

Nit: the two . here will match any character (not just the literal .), you can fix that by escaping them:

MacOSX([0-9]+\.[0-9]+)\.sdk

This comment has been minimized.

@a2sheppy

a2sheppy Jul 2, 2012

Contributor

Marshall Culpepper wrote:

Nit: the two . here will match any character (not just the literal .), you can fix that by escaping them:

MacOSX([0-9]+\.[0-9]+)\.sdk

I unfortunately can't fix it right now; the computer I have that has all
my code (and the hard drive for my laptop) is at home and I'm on vacation.

Eric

@a2sheppy

a2sheppy Jul 2, 2012

Contributor

Marshall Culpepper wrote:

Nit: the two . here will match any character (not just the literal .), you can fix that by escaping them:

MacOSX([0-9]+\.[0-9]+)\.sdk

I unfortunately can't fix it right now; the computer I have that has all
my code (and the hard drive for my laptop) is at home and I'm on vacation.

Eric

scripts/bootstrap-mac.sh
- echo "Error: Could not find MacOSX10.6.sdk in this location:"
- echo " $osx_106_sdk"
+ if [ ! -d "$osx_sdk" ]; then
+ echo "Error: Could not find Mac OS X $sdk_ver SDK in this location:"

This comment has been minimized.

@marshall

marshall Jul 2, 2012

Contributor

IIRC we actually require the 10.6 SDK in our AOSP build, but I guess 10.7 (or 10.8) worked for you in Mountain Lion?

@marshall

marshall Jul 2, 2012

Contributor

IIRC we actually require the 10.6 SDK in our AOSP build, but I guess 10.7 (or 10.8) worked for you in Mountain Lion?

This comment has been minimized.

@a2sheppy

a2sheppy Jul 2, 2012

Contributor

Marshall Culpepper wrote:

IIRC we actually require the10.6 SDK in our AOSP build, but I guess10.7 (or10.8) worked for you in Mountain Lion?

There is no 10.6 SDK in Mountain Lion; only 10.7 and 10.8. I admit I
didn't actually test the 10.8 SDK, which is why it's a last resort
fallback. We can remove that if we're not comfortable leaving that in.

But the 10.7 SDK worked fine for me.

Eric

@a2sheppy

a2sheppy Jul 2, 2012

Contributor

Marshall Culpepper wrote:

IIRC we actually require the10.6 SDK in our AOSP build, but I guess10.7 (or10.8) worked for you in Mountain Lion?

There is no 10.6 SDK in Mountain Lion; only 10.7 and 10.8. I admit I
didn't actually test the 10.8 SDK, which is why it's a last resort
fallback. We can remove that if we're not comfortable leaving that in.

But the 10.7 SDK worked fine for me.

Eric

@a2sheppy a2sheppy merged commit 6940177 into mozilla-b2g:master Jul 19, 2012

@a2sheppy a2sheppy referenced this pull request Jul 19, 2012

Merged

Update to handle OS X 10.8 #75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment