Bug 810045: change dhcp client for eth0 #12

Merged
merged 2 commits into from Nov 30, 2012

Conversation

Projects
None yet
4 participants
Contributor

dividehex commented Nov 27, 2012

When 'netcfg' is called to initialize and obtain an IP from dhcp it fails
on vlans with heavy dhcp traffic. This patch changes init to call
dhcpcd instead since it handles timeouts and invalid replies better.
This also changes sut to start after dhcpcd forks and exits.

@dividehex dividehex Bug 810045: change dhcp client for eth0
When 'netcfg' is called to initialize and obtain an IP from dhcp it fails
on vlans with heavy dhcp traffic.  This patch changes init to call
dhcpcd instead since it handles timeouts and invalid replies better.
This also changes sut to start after dhcpcd forks and exits.
88279c5
Contributor

michaelwu commented Nov 28, 2012

@tdz , want to review?

@tdz tdz commented on an outdated diff Nov 28, 2012

init.omap4pandaboard.rc
@@ -90,8 +90,8 @@ service iprenew_wlan0 /system/bin/dhcpcd -n
disabled
oneshot
-service dhcpcd_eth0 /system/bin/dhcpcd -ABKL
- disabled
+service dhcpcd_eth0 /system/bin/dhcpcd eth0
+ main class
@tdz

tdz Nov 28, 2012

Contributor

This should be 'class main'.

@tdz tdz commented on an outdated diff Nov 28, 2012

init.omap4pandaboard.rc
@@ -99,7 +99,7 @@ service iprenew_eth0 /system/bin/dhcpcd -n
oneshot
service netcfg_eth0 /system/bin/netcfg eth0 dhcp
- class main
+ disabled
oneshot
@tdz

tdz Nov 28, 2012

Contributor

Please remove the whole service declaration.

@tdz Do you think you can get to this review before the weekend? The sooner we get this reviewed and landed, the sooner we unblock release engineering. Many many thanks.

Contributor

tdz commented Nov 30, 2012

Sorry. I must have missed that there was an update. I'm fine with the changes; and good work, dividehex. Sorry again.

tdz merged commit 63196b4 into mozilla-b2g:master Nov 30, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment