Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Handle empty propstat by sending false #10

Merged
merged 1 commit into from Jan 28, 2013

Conversation

Projects
None yet
2 participants
Contributor

lightsofapollo commented Jan 28, 2013

No description provided.

Contributor

lightsofapollo commented Jan 28, 2013

Handles cases like this:

[09:28:53.074] [ caldav worker ] XHR: (207) <?xml version="1.0" encoding="UTF-8"?>
<D:multistatus xmlns:D="DAV:" xmlns:caldav="urn:ietf:params:xml:ns:caldav" xmlns:cs="http://calendarserver.org/ns/" xmlns:ical="http://apple.com/ns/ical/">
 <D:response>

  <D:href>/calendar/dav/dq4gmrtcs20u27acuudnfsbjbk%40group.calendar.google.com/events/</D:href>
  <D:propstat>
   <D:status>HTTP/1.1 404 Not Found</D:status>
  </D:propstat>
 </D:response>
</D:multistatus>

The server sends 207 but there is no content so we read the propstat...

@KevinGrandon KevinGrandon commented on an outdated diff Jan 28, 2013

test/caldav/sax/dav_response_test.js
@@ -124,6 +125,8 @@ suite('caldav/sax/dav_response', function() {
subject.once('complete', function(data) {
+ console.log(JSON.stringify(data.multistatus));
@KevinGrandon

KevinGrandon Jan 28, 2013

Owner

Nit: remove these?

Or - maybe add some notes as to what's being logged so we know what's being logged when we run the test in the future?

Owner

KevinGrandon commented Jan 28, 2013

Makes sense, r=me.

KevinGrandon added a commit that referenced this pull request Jan 28, 2013

Merge pull request #10 from mozilla-b2g/empty-propstat
Handle empty propstat by sending false

@KevinGrandon KevinGrandon merged commit ee5ae7a into master Jan 28, 2013

lightsofapollo added a commit that referenced this pull request Jan 28, 2013

Revert "Merge pull request #10 from mozilla-b2g/empty-propstat"
This reverts commit ee5ae7a, reversing
changes made to 75c6e99.

lightsofapollo added a commit that referenced this pull request Jan 28, 2013

Merge pull request #11 from mozilla-b2g/revert-bad-commit
Revert "Merge pull request #10 from mozilla-b2g/empty-propstat"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment