Bug 939375 - [email] POP3: UX for when there are too many messages in the spool. #267

Merged
merged 1 commit into from Dec 4, 2013

Conversation

Projects
None yet
2 participants
Contributor

mcav commented Dec 3, 2013

No description provided.

data/lib/mailapi/pop3/sync.js
@@ -421,12 +531,23 @@ Pop3FolderSyncer.prototype = {
latch.then((function onSyncDone() {
this._LOG.sync_end();
- // POP3 always syncs the entire time range available.
+
+ // XXX: Here, I want to mark an accurate sync range, but using
@asutherland

asutherland Dec 4, 2013

Member

This is basically the right thing to be doing here. The accuracy range info is effectively meaningless for POP3 because we have no meta-data for messages to update and our sync is not actually time-aware. Really all POP3 wants out of of this is for:

  • syncedToDawnOfTime() to return false while "this.hasOverflowMessages()" is true. And you've done that here
  • To avoid refresh-style synchronizations while scrolling the list. IMAP does those to refresh meta-data, but it's absolutely not needed for POP3. By setting the range nearly maximally, you're accomplishing this.

Really, what we want to do is move more of this date range logic into the ImapFolderSyncer class or some other support class.

mcav added a commit that referenced this pull request Dec 4, 2013

Merge pull request #267 from mcav/pop3-spool-too-big
Bug 939375 - [email] POP3: UX for when there are too many messages in the spool. r=asuth

@mcav mcav merged commit fb921c4 into mozilla-b2g:master Dec 4, 2013

1 check passed

default The Travis CI build passed
Details

@mcav mcav deleted the mcav:pop3-spool-too-big branch Jul 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment