Bug 942795 - [email] autoconfig XHR callbacks seem to be firing multiple times on nightly, may produce duplicate accounts; investigate XHR event changes, switch to promises #276

Merged
merged 1 commit into from Dec 13, 2013

Conversation

Projects
None yet
2 participants
Contributor

mcav commented Dec 12, 2013

No description provided.

Bug 942795 - [email] autoconfig XHR callbacks seem to be firing multi…
…ple times on nightly, may produce duplicate accounts; investigate XHR event changes, switch to promises
@@ -17,7 +17,6 @@ function FakeXHR() {
};
this.onload = null;
- this.onerror = null;
@asutherland

asutherland Dec 12, 2013

Member

For shape consistency, you would ideally change this to this._onerror. In practice this does not matter at all for test code like this, so it's okay to not fix, just be aware.

mcav added a commit that referenced this pull request Dec 13, 2013

Merge pull request #276 from mcav/autoconfig-xhr
Bug 942795 - [email] autoconfig XHR callbacks seem to be firing multiple times on nightly. r=asuth a=fabrice

@mcav mcav merged commit a781705 into mozilla-b2g:master Dec 13, 2013

1 check passed

default The Travis CI build passed
Details

@mcav mcav deleted the mcav:autoconfig-xhr branch Jul 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment