Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Commit

Permalink
Merge pull request #25722 from patelba/1068918
Browse files Browse the repository at this point in the history
Bug 1068918 - [Camera] Preview header should be first thing in markup
  • Loading branch information
wilsonpage committed Nov 2, 2014
2 parents 8ca1a7b + 73be42b commit 1aff2e0
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion apps/camera/js/app.js
Expand Up @@ -110,8 +110,8 @@ App.prototype.runControllers = function() {
this.controllers.activity(this);
this.controllers.camera(this);
this.controllers.viewfinder(this);
this.controllers.controls(this);
this.controllers.hud(this);
this.controllers.controls(this);
debug('controllers run');
};

Expand Down
10 changes: 5 additions & 5 deletions apps/camera/js/views/preview-gallery.js
Expand Up @@ -89,10 +89,7 @@ return View.extend({
},

template: function() {
return '<div class="frame-container js-frame-container">' +
'<div class="media-frame js-media-frame"></div>' +
'</div>' +
'<div class="preview-menu js-preview-menu">' +
return '<div class="preview-menu js-preview-menu">' +
'<gaia-header class="js-header" action="back">' +
'<h1 data-l10n-id="preview">Preview</h1>' +
'<button class="preview-share-icon js-share"' +
Expand All @@ -101,7 +98,10 @@ return View.extend({
'js-options" name="options" data-icon="more"></button>' +
'</gaia-header>' +
'</div>' +
'<div class="count-text js-count-text"></div>';
'<div class="frame-container js-frame-container">' +
'<div class="media-frame js-media-frame"></div>' +
'</div>' +
'<div class="count-text js-count-text"></div>';
},

onTap: function() {
Expand Down
3 changes: 2 additions & 1 deletion apps/camera/style/preview-gallery.css
Expand Up @@ -61,7 +61,8 @@
*/

.preview-menu {
position: relative; /* 1 */
position: relative;
z-index: 1; /* 1 */
opacity: 0;
visibility: hidden;
pointer-events: none;
Expand Down

0 comments on commit 1aff2e0

Please sign in to comment.