From 00a6932b2e29d4ab2e615ce6487a128136be8af1 Mon Sep 17 00:00:00 2001 From: Carmen Jimenez Cabezas Date: Wed, 18 Dec 2013 10:53:45 +0100 Subject: [PATCH] Bug 951552 - Incorrect behavior when first boot is run with a pin locked SIM (and no PIN is entered) --- apps/communications/ftu/js/operatorVariant.js | 18 +++--------------- .../ftu/test/unit/operatorVariant_test.js | 2 +- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/apps/communications/ftu/js/operatorVariant.js b/apps/communications/ftu/js/operatorVariant.js index fa8318da2906..c80335519aa3 100644 --- a/apps/communications/ftu/js/operatorVariant.js +++ b/apps/communications/ftu/js/operatorVariant.js @@ -15,13 +15,13 @@ var OperatorVariant = (function() { * If ftu.simPresentOnFirstBoot setting has value do nothing otherwise * set ftu.simPresentOnFirstBoot = true if * IccHelper.cardState value is: + * 'ready'. + * otherwise set to false. * 'pinRequired', * 'pukRequired', * 'networkLocked', * 'corporateLocked', * 'serviceProviderLocked', - * 'ready'. - * otherwise set to false. */ function setSIMOnFirstBootState() { var cardState; @@ -44,19 +44,7 @@ var OperatorVariant = (function() { req.onsuccess = function ov_onsuccess() { var currentStatus = req.result['ftu.simPresentOnFirstBoot']; if (currentStatus === undefined || currentStatus === null) { - switch (cardState) { - case 'pinRequired': - case 'pukRequired': - case 'networkLocked': - case 'corporateLocked': - case 'serviceProviderLocked': - case 'ready': - setIsSIMPresentOnFirstBoot(true); - break; - default: - setIsSIMPresentOnFirstBoot(false); - break; - } + setIsSIMPresentOnFirstBoot(cardState === 'ready'); } cardState = null; }; diff --git a/apps/communications/ftu/test/unit/operatorVariant_test.js b/apps/communications/ftu/test/unit/operatorVariant_test.js index bb7d6ebea3e4..6a874b1f4472 100644 --- a/apps/communications/ftu/test/unit/operatorVariant_test.js +++ b/apps/communications/ftu/test/unit/operatorVariant_test.js @@ -54,7 +54,7 @@ suite('operatorVariant set First run state >', function() { }, { 'preValSet': undefined, - 'expecValSet': true, + 'expecValSet': false, 'cardState': 'pinRequired', 'title': 'Operator Variant set first run type - sim pinRequired' },