Merge pull request #9596 from gtorodelvalle/dialer-bug-869446-fix-cal…

…l-log-filters

Bug 869446 - [Dialer][BB] Adapting the Call Log filters to the latest up dates in the Tab BB (r=crdlc)

apps/communications/dialer/js/recents.js

@@ -227,8 +227,8 @@ var Recents = {
   },
 
   filter: function re_filter(event) {
-    // do nothing if selected tab is same that current
-    if (event.target.parentNode.classList.contains('selected')) {
+    // Do nothing if the selected tab is same that current
+    if (event.target.parentNode.getAttribute('aria-selected') === "true") {
       return;
     }
     var action = event.target.dataset.action;
@@ -326,8 +326,16 @@ var Recents = {
         this._missedViewGroupingPending = false;
       }
     }
-    this.allFilter.classList.toggle('selected');
-    this.missedFilter.classList.toggle('selected');
+    if (this.allFilter.getAttribute('aria-selected') === 'true') {
+      this.allFilter.removeAttribute('aria-selected');
+    } else {
+      this.allFilter.setAttribute('aria-selected', 'true')
+    }
+    if (this.missedFilter.getAttribute('aria-selected') === 'true') {
+      this.missedFilter.removeAttribute('aria-selected');
+    } else {
+      this.missedFilter.setAttribute('aria-selected', 'true');
+    }
     this.limitVisibleEntries(100);
   },
 
@@ -608,7 +616,7 @@ var Recents = {
         '</div>';
       navigator.mozL10n.translate(this.recentsContainer);
       this.recentsIconEdit.parentNode.setAttribute('aria-disabled', 'true');
-      this.allFilter.classList.add('selected');
+      this.allFilter.setAttribute('aria-selected', 'true');
       return;
     }
 
@@ -644,18 +652,18 @@ var Recents = {
       var event = new Object();
       self._allViewGroupingPending = true;
       self._missedViewGroupingPending = true;
-      if (self.missedFilter.classList.contains('selected')) {
-        self.missedFilter.classList.remove('selected');
+      if (self.missedFilter.getAttribute('aria-selected') === 'true') {
+        self.missedFilter.removeAttribute('aria-selected');
         event.target = self.missedFilter.children[0];
         self.filter(event);
-        self.missedFilter.classList.add('selected');
-        self.allFilter.classList.remove('selected');
+        self.missedFilter.setAttribute('aria-selected', 'true');
+        self.allFilter.removeAttribute('aria-selected');
       } else {
-        self.allFilter.classList.remove('selected');
+        self.allFilter.removeAttribute('aria-selected');
         event.target = self.allFilter.children[0];
         self.filter(event);
-        self.missedFilter.classList.remove('selected');
-        self.allFilter.classList.add('selected');
+        self.missedFilter.removeAttribute('aria-selected');
+        self.allFilter.setAttribute('aria-selected', 'true');
       }
     });
   },

apps/communications/dialer/style/commslog.css

@@ -55,26 +55,6 @@ ol, ul {
   list-style: none;
 }
 
-/* Copying Filters BB styles for selected filter, but using .selected instead of :target */
-ul[role="tablist"][data-type="filter"] > [role="tab"].selected {
-  background: #fff;
-  border: solid 1px #999;
-  border-top: none;
-  color: #000;
-}
-
-ul[role="tablist"][data-type="filter"] > [role="tab"]:first-child.selected {
-  border-left: none;
-}
-
-ul[role="tablist"][data-type="filter"] > [role="tab"]:last-child.selected {
-  border-right: none;
-}
-
-ul[role="tablist"][data-type="filter"] > [role="tab"].selected > a {
-  color: #000;
-}
-
 .hide {
   display: none;
 }