diff --git a/apps/sms/index.html b/apps/sms/index.html index e28467991f0b..0274b80425e2 100644 --- a/apps/sms/index.html +++ b/apps/sms/index.html @@ -193,7 +193,7 @@

Edit mode

${nameHTML}

- ${type} ${numberHTML} ${carrier} + ${type} ${numberHTML}

--> diff --git a/apps/sms/js/thread_ui.js b/apps/sms/js/thread_ui.js index 95a326e12135..0f6f6dc04447 100644 --- a/apps/sms/js/thread_ui.js +++ b/apps/sms/js/thread_ui.js @@ -1381,13 +1381,13 @@ var ThreadUI = global.ThreadUI = { var current = tels[i]; var number = current.value; var title = details.title || number; + var type = current.type ? (current.type + ' |') : ''; var contactLi = document.createElement('li'); var data = { name: Utils.escapeHTML(title), number: Utils.escapeHTML(number), - type: current.type || '', - carrier: current.carrier || '', + type: type, srcAttr: details.photoURL ? 'src="' + Utils.escapeHTML(details.photoURL) + '"' : '', nameHTML: '', diff --git a/apps/sms/test/unit/mock_utils.js b/apps/sms/test/unit/mock_utils.js index 68ec68584c7b..7dafa1cbb261 100644 --- a/apps/sms/test/unit/mock_utils.js +++ b/apps/sms/test/unit/mock_utils.js @@ -17,6 +17,7 @@ var MockUtils = { typeFromMimeType: Utils.typeFromMimeType, escapeHTML: Utils.escapeHTML, escapeRegex: Utils.escapeRegex, + getContactDetails: Utils.getContactDetails, Message: { format: function(str) { return str; } } diff --git a/apps/sms/test/unit/thread_ui_test.js b/apps/sms/test/unit/thread_ui_test.js index e99ae1bbb21c..5a3281f6eed7 100644 --- a/apps/sms/test/unit/thread_ui_test.js +++ b/apps/sms/test/unit/thread_ui_test.js @@ -1340,6 +1340,56 @@ suite('thread_ui.js >', function() { }); }); + suite('Render Contact', function() { + + test('Rendered Contact "givenName familyName"', function() { + var ul = document.createElement('ul'); + var contact = new MockContact(); + var html; + + ThreadUI.renderContact(contact, 'foo', ul); + html = ul.firstElementChild.innerHTML; + assert.ok(html.contains('Pepito Grillo')); + }); + + test('Rendered Contact highlighted "givenName familyName"', function() { + var ul = document.createElement('ul'); + var contact = new MockContact(); + var html; + + ThreadUI.renderContact(contact, 'Pepito Grillo', ul); + html = ul.firstElementChild.innerHTML; + + assert.ok( + html.contains('Pepito') + ); + assert.ok( + html.contains('Grillo') + ); + }); + + test('Rendered Contact "type | number"', function() { + var ul = document.createElement('ul'); + var contact = new MockContact(); + var html; + + ThreadUI.renderContact(contact, 'foo', ul); + html = ul.firstElementChild.innerHTML; + assert.ok(html.contains('Mobile | +346578888888')); + }); + + test('Rendered Contact highlighted "type | number"', function() { + var ul = document.createElement('ul'); + var contact = new MockContact(); + var html; + + ThreadUI.renderContact(contact, '346578888888', ul); + html = ul.firstElementChild.innerHTML; + assert.ok( + html.contains('Mobile | +346578888888') + ); + }); + }); suite('Header Actions', function() { setup(function() {