Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Bug 904990 - [Clock] Switching from Alarm Edit back to Clock with "Done" may lose the display #11561

Closed
wants to merge 1 commit into from

Conversation

rwaldron
Copy link
Contributor

https://bugzilla.mozilla.org/show_bug.cgi?id=904990

  • Removes the unnecessary the "hide" logic

Signed-off-by: Rick Waldron waldron.rick@gmail.com

@rwaldron
Copy link
Contributor Author

The travis-ci failure is unrelated to this patch

@ian-liu
Copy link
Contributor

ian-liu commented Aug 16, 2013

@rwaldron
I still can reproduce the issue while clicking "Done" button quickly. You could try to click on the right-top corner. Just clicking the area over add/done button. And please don't wait the animation end. Maybe you can reproduce what I say. But the reproduced rated is 2/10. Looks like the timer of display is missed to clear up.

…ne" may lose the display

https://bugzilla.mozilla.org/show_bug.cgi?id=904990

- Removes the unnecessary the "hide" logic

Signed-off-by: Rick Waldron <waldron.rick@gmail.com>
@jugglinmike
Copy link
Contributor

@rwaldron Asked me to test this latest patch, and I have been unable to reproduce the hidden clock bug the @ian-liu identified in an earlier version.

@ian-liu
Copy link
Contributor

ian-liu commented Aug 19, 2013

The patch works for me. r=me.

If we want to hide the clock face in the alarm-edit page, maybe we can use and monitor "animationend" event to hide it. But it could be still having time issue. That's a better have patch in the future. Thank for @rwaldron and @jugglinmike 's effort.

@jugglinmike
Copy link
Contributor

If we want to hide the clock face in the alarm-edit page, maybe we can use and monitor "animationend" event to hide it.

@ian-liu I totally agree, but I'm curious: do you know why we need to explicitly hide the clock face when the "Alarm Edit" viewed is displayed? Since it is a full-screen view, it completely obstructs the clock, so (at first glance) the hiding seems unnecessary.

@ian-liu
Copy link
Contributor

ian-liu commented Aug 20, 2013

@jugglinmike
Yes, it's unnecessary to hide it. But I think it's to be a cost-effective and saving power to hide the clock face(clean up the update timer) while we don't see the clock face. So, a better have work.

@rwaldron rwaldron closed this Oct 24, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants