Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug 844717] - [Keyboard][V1.2] Add Thai keyboard layout #12239

Closed
wants to merge 151 commits into from

Conversation

Projects
None yet
@veer66
Copy link

commented Sep 16, 2013

Add Thai keyboard layout based on Pittaya's patch

@arky

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2013

Thanks @veer66 !

@pureexe

This comment has been minimized.

Copy link

commented Sep 16, 2013

Thank you
make it easy for thai people 👍

@julienw

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2013

Would it be a good idea to make it a third-party keyboard instead of building it into gaia ? Would make it easy for partners to include or exclude it, and in case it's excluded, for users to install it from the marketplace.

@arky

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2013

  • 1
    @julienw Can you point us to docs or examples for creating such third-party keyboards.
@julienw

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2013

MDN is not yet updated, the most current information is at https://wiki.mozilla.org/WebAPI/KeboardIME#Proposed_Manifest_of_a_3rd-Party_IME

Also, @mpizza has an example there: https://github.com/mpizza/ime

@RudyLu do you know if there are better docs ?

@veer66

This comment has been minimized.

Copy link
Author

commented Sep 16, 2013

@julienw I have no idea why people want to exclude a keyboard layout that requires less than 5 KiB space even before it has been compressed. In term of number of language speakers, there are 60 million speakers, which is larger than number of speakers of many keyboard layouts, which are already built-in.

I plan to publish a statistical based keyboard with Thai dictionary as a separated app but the plain one might be better to be built-in. However if it is really necessary, I will try make the plain one as a separated app too.

@julienw

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2013

This is not only space, this is also UI cluttering.

But I merely did a proposal here, I'm not an owner or peer of keyboard so please don't take my advice for something to do :)

@veer66

This comment has been minimized.

Copy link
Author

commented Sep 16, 2013

@julienw Thank you for your advice. Eventually I may have to do exactly what you said. However, at least, I think should explain everyone the situation of Thai language. :-)

@RudyLu

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2013

Hi all,

So far the wiki page, https://wiki.mozilla.org/WebAPI/KeboardIME#Proposed_Manifest_of_a_3rd-Party_IME is the best we have for 3rd-party IME documentation.
You may want to take a look at our test_apps/test-keyboard-app/ as a simple example.

@veer66,
I know nothing about Thai, so as David commented on the bug, I think we can accept this patch into our built-in keyobard app if simply adding the layout could serve most of Thai speakers.
If they would need at least a dictionary for auto correction or something, then we would suggest we move it into a separate app.
(Will leave this to bugzilla for record.)

Thanks.

@veer66

This comment has been minimized.

Copy link
Author

commented Sep 17, 2013

@RudyLu The layout only is enough. I don't think we need auto correction, dictionary, etc.

gasolin and others added some commits Sep 16, 2013

Merge pull request #12294 from Pike/bug-917692-update-languages_all-t…
…o_dev

Bug 917692 update languages all to dev, r=kaze
Merge pull request #12253 from nullaus/agps-unit-tests
bug 891732 - AGPS/SUPL Operator Variant Unit Tests. r=jaoo
Revert "Bug 911696 - [Dialer] [Flatfish] hide dialer app in homescree…
…n if no telephony support"

This reverts commit 4cfe366.
Merge pull request #12303 from KevinGrandon/kevin-v1.2
Revert "Bug 911696 - [Dialer] [Flatfish] hide dialer app in homescreen if no telephony support" r=fabrice
Revert "Merge pull request #12234 from EragonJ/bug-914317"
This reverts commit bda5c4a, reversing
changes made to bc85e07.
Revert "Merge pull request #12323 from nullaus/891724-supportcontactc…
…ustomization" due to test failures

This reverts commit 534c040.
Merge pull request #12076 from gaye/bug-821519-again
Bug 821519 - Enable sharing urls from the browser through email r=jrburke(cherry picked from commit c6b4cc0)
Merge pull request #12177 from steveck-chung/issue913378
Bug 913378 - Redesign of incoming call screen - Gaia implementation. r=etienne a=koi+(cherry picked from commit 5d5089d)
Merge pull request #12296 from gtorodelvalle/contacts-bug-910170-expo…
…rt-button-not-disabled

Bug 910170 - [CONTACTS] The export button isn't disabled when no contact is selected (r=jmcanterafonseca).(cherry picked from commit c538b69)
Merge pull request #11889 from borjasalguero/madrid_getdisplayinfo
Bug 900443 - [SMS] Remove repeated request to Contacts API when retrievi...(cherry picked from commit 87e0df1)
Merge pull request #12270 from fcampo/BT-exportVcard-887534
Bug 887534 - [US] Send contact as a VCARD via bluetooth (r=borjasalguero)(cherry picked from commit 53a8671)
Merge pull request #12312 from borjasalguero/followup_sms
Bug 918302 - [Followup 900443][SMS] Add a robust check when retrieving a...(cherry picked from commit 132dd57)
Merge pull request #12326 from nullaus/891724-supportcontactcustomiza…
…tion

891724 supportcontactcustomization(cherry picked from commit bc00bf3)
Merge pull request #11914 from davidflanagan/bug905856
Bug 905856: support locked media files r=johu,dkuo,hsivonen,kaze(cherry picked from commit be94cd5)
Merge pull request #12318 from wanderview/contacts-css-opt-2
Bug 918174: Load CSS from contacts index.html  r=jmcf(cherry picked from commit 587b684)
Merge pull request #12249 from reubenmorais/contacts-customization
Bug 891723 - Implement preloaded contacts customization by SIM(cherry picked from commit 3610f98)
Bug 917337 - [Clock] Implement Scrolling for Timer Settings
https://bugzilla.mozilla.org/show_bug.cgi?id=917337

- Adds overflow-y: auto to #timer-dialog
- Adds a event.preventDefault() on touchstart on the time picker to stop user from scrolling while spinning inputs

r=jugglinmike
(cherry picked from commit 909f188)

daleharvey and others added some commits Oct 2, 2013

Bug 914454 - Ensure SMS messages in only uppercase Greek letters are …
…sent with 7bit encoding on the carrier partner network r=rwaldron

Set x-inputmode=-moz-sms-7bit for SMS only
(cherry picked from commit 4e14ffa)
Merge pull request #12661 from jmcanterafonseca/fix_sim_call2
Bug 918582 - [B2G] [Buri] [Contacts] User sees no response when tapping ...(cherry picked from commit 1ac6749)
Merge pull request #12649 from etiennesegonzac/bug-920940-call-direction
Bug 920940 - Fixing a regression where the "direction" of the call wasn't displayed. r=rik(cherry picked from commit 0b6cc50)
Merge pull request #12585 from etiennesegonzac/bug-915573-custom-tel-…
…type

Bug 915573 - Do not translate custom phone types in the call screen additional infos. r=rik(cherry picked from commit b6177f2)
Merge pull request #12626 from etiennesegonzac/bug-920422-add-call-wo…
…rkflow

Bug 920422 - Showing the contacts tab when we place a new call from the call screen. r=rik(cherry picked from commit 47f50a6)
Merge pull request #12679 from cctuan/922964
Bug 922964 - put the preload iframe farer(cherry picked from commit 2ced1b0)
Merge pull request #12608 from gasolin/issue-923022
Bug 923022 - [Flatfish] correct the tablet app list, r=timdream(cherry picked from commit b3a7b9c)
Merge pull request #12699 from timdream/timezone-bug813987
Bug 916068 - make sure tzselector still works w/o voice network, r=evelyn(cherry picked from commit c3cc920)
Bug 910168 - When long pressing u key in Spanish keyboard, the first …
…suggested letter is ü, it should be ú - r=rlu

- Switch the order of ü and ú in the alternates
(cherry picked from commit 3df055e)
Merge pull request #12673 from wanderview/contacts-dynamic-group
Bug 921683: defer contact group DOM creation. r=jmcf(cherry picked from commit cbb6174)
Merge pull request #12697 from evelynhung/issue-900399-v1.2
Merge pull request #12417 from evelynhung/issue-900399
Zac
Merge pull request #12726 from teodosia/bug-924420
Bug 924420 -  Fix failing settings/test_settings_change_keyboard_language.py on aurora
@arky

This comment has been minimized.

Copy link
Contributor

commented Nov 6, 2013

@veer66 Can you update and test your thai keyboard layout.

How to test the keyboard with desktop b2g client:

Checkout this branch: https://github.com/arky/gaia/tree/Thai-FxOS-Keyboard

cd gaia

GAIA_KEYBOARD_LAYOUTS=en,th make

b2g -profile ./profile

Once the desktop b2g client starts. Enable Thai keyboard in Settings apps.

Once the keyboard layout is usable. We can add word list to create autocorrection feature.

@pureexe

This comment has been minimized.

Copy link

commented Nov 9, 2013

@arky
that look great
merge it please

@arky

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2013

This keyboard needs more testing. Am not a native speaker. @pureexe Can you please help?

@veer66

This comment has been minimized.

Copy link
Author

commented Nov 14, 2013

@arky @pureexe and me are testing this ^^.

@pureexe

This comment has been minimized.

Copy link

commented Nov 14, 2013

@arky something wrong
not found thai on setting > keyboard > select keyboard
i try to compare thai keyboard with Myanmar keyboard (from arky@3eea4fa)

maybe you forgot to add "th" in "shared/resources/keyboard_layouts.json"?

@arky

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2013

You will find the instructions in my previous comment here.

@pureexe

This comment has been minimized.

Copy link

commented Nov 15, 2013

@arky
something wrong
when i try to press "(" on keyboard it display "ผ"

@arky

This comment has been minimized.

Copy link
Contributor

commented Nov 15, 2013

Thanks for the feedback. Am gonna try to fix this in the morning.

@pureexe

This comment has been minimized.

Copy link

commented Nov 15, 2013

@arky from previous comment

bug is upper character (keyboard display a upper character but when type it type lower charater)
because Thai language upper character and lower character is different (not like english language)

sorry for my bad english :(

@arky

This comment has been minimized.

Copy link
Contributor

commented Nov 18, 2013

@pureexe Most of the issues that you pointed out are present in original @veer66 patch. Might be a good idea to rework the keyboard layout and send a new patch.

@arky

This comment has been minimized.

Copy link
Contributor

commented Nov 20, 2013

@veer66 Perhaps you could close this pull request. This keyboard needs reworking.

@veer66

This comment has been minimized.

Copy link
Author

commented Nov 20, 2013

@arky Thank you. I will pull request the new one soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.