This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 921056 - Visual polish for status bar #12658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rik
commented
Oct 3, 2013
rik
commented
- CallScreen.isStatusBarMode to be DRY-er
- HandledCall.formatPhoneNumber will format according to isStatusBarMode
- Don't display lockscreen elements and group call details in status bar
- Use new icons
- Adjust spacing
- Held mode should be dark gray
| @@ -702,6 +702,13 @@ suite('dialer/handled_call', function() { | |||
| }); | |||
|
|
|||
| suite('phone number', function() { | |||
| test('formatPhoneNumber', function() { | |||
There was a problem hiding this comment.
nit: I know the rest of the suite isn't top notch but I'd go with:
formatPhoneNumber in status bar mode should reset the fontsize
- CallScreen.isStatusBarMode to be DRY-er - HandledCall.formatPhoneNumber will format according to isStatusBarMode - Don't display lockscreen elements and group call details in status bar - Use new icons - Adjust spacing - Held mode should be dark gray
|
green travis! |
etiennesegonzac
added a commit
that referenced
this pull request
Oct 4, 2013
Bug 921056 - Visual polish for status bar r=etienne
etiennesegonzac
added a commit
that referenced
this pull request
Oct 22, 2013
Bug 921056 - Visual polish for status bar r=etienne(cherry picked from commit f1c6218)
viorelaioia-zz
pushed a commit
to viorelaioia-zz/gaia
that referenced
this pull request
Oct 24, 2013
Bug 921056 - Visual polish for status bar r=etienne(cherry picked from commit f1c6218)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.