Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1113662 - [v2.2] Investigate test_sms_with_attachments tap_capture f... #27115

Merged
merged 1 commit into from Jan 27, 2015

Conversation

Projects
None yet
7 participants
@viorelaioia
Copy link
Contributor

commented Jan 5, 2015

...ailure

@try-server-hook

This comment has been minimized.

Copy link

commented Jan 5, 2015

viorelaioia viorelaioia started tests. Results

@viorelaioia viorelaioia force-pushed the viorelaioia:bug_1113662 branch from 894446b to ca21443 Jan 6, 2015

@try-server-hook

This comment has been minimized.

Copy link

commented Jan 6, 2015

viorelaioia viorelaioia started tests. Results

@viorelaioia viorelaioia force-pushed the viorelaioia:bug_1113662 branch from ca21443 to f2c4bff Jan 7, 2015

@try-server-hook

This comment has been minimized.

Copy link

commented Jan 7, 2015

viorelaioia viorelaioia started tests. Results

@@ -53,6 +53,8 @@ def tap_camera(self):
camera = Camera(self.marionette)
self.wait_for_condition(lambda m: self.apps.displayed_app.name == camera.name)
self.apps.switch_to_displayed_app()
camera.wait_for_loading_spinner_displayed()
camera.wait_for_loading_spinner_hidden()

This comment has been minimized.

Copy link
@chirarobert

chirarobert Jan 8, 2015

Contributor

I suggest moving these 2 lines in wait_for_capture_ready(). The way they will run in all of the instances where we use the camera app. We should test this thoroughly so that we don't break other tests.

This comment has been minimized.

Copy link
@bebef1987

This comment has been minimized.

Copy link
@viorelaioia

viorelaioia Jan 16, 2015

Author Contributor

I tried to do that, but I'm getting intermittent failures of other camera tests that are using this method. As I noticed, sometimes the spinner is displayed just for ~1 sec or not at all in tests that are launching camera from Homescreen.
Though, while launching it from another app, like Messages in our case, it takes more time to load, so the loading spinner is displayed for more time.
So I'd rather use this methods independently, and not adding them in wait_for_capture_ready()

@viorelaioia viorelaioia force-pushed the viorelaioia:bug_1113662 branch from f2c4bff to f1fba15 Jan 8, 2015

@try-server-hook

This comment has been minimized.

Copy link

commented Jan 8, 2015

viorelaioia viorelaioia started tests. Results

@viorelaioia viorelaioia force-pushed the viorelaioia:bug_1113662 branch from f1fba15 to 9c09fb4 Jan 8, 2015

@try-server-hook

This comment has been minimized.

Copy link

commented Jan 8, 2015

viorelaioia viorelaioia started tests. Results

@viorelaioia viorelaioia force-pushed the viorelaioia:bug_1113662 branch 4 times, most recently from 85abdfc to fbaf2fc Jan 8, 2015

@try-server-hook

This comment has been minimized.

Copy link

commented Jan 12, 2015

viorelaioia viorelaioia started tests. Results

@viorelaioia viorelaioia force-pushed the viorelaioia:bug_1113662 branch from fbaf2fc to 0bf6b0c Jan 14, 2015

@try-server-hook

This comment has been minimized.

Copy link

commented Jan 14, 2015

viorelaioia viorelaioia started tests. Results

@viorelaioia viorelaioia force-pushed the viorelaioia:bug_1113662 branch from 0bf6b0c to 93fc461 Jan 14, 2015

@try-server-hook

This comment has been minimized.

Copy link

commented Jan 14, 2015

viorelaioia viorelaioia started tests. Results

@viorelaioia

This comment has been minimized.

@@ -20,7 +20,7 @@ class Camera(Base):
_secure_camera_frame_locator = (By.CSS_SELECTOR, ".secureAppWindow.active[data-manifest-name='Camera'] iframe")

# Controls View
_controls_locator = (By.CSS_SELECTOR, '.controls')
_controls_locator = (By.CSS_SELECTOR, '.controls.enabled')

This comment has been minimized.

Copy link
@JohanLorenzo

JohanLorenzo Jan 16, 2015

Contributor

Why do we change this locator? You don't use it in wait_for_loading_spinner_hidden, wait_for_loading_spinner_hidden or tap_capture.

This comment has been minimized.

Copy link
@viorelaioia

viorelaioia Jan 16, 2015

Author Contributor

This change is not required. I tried several ways to fix this issue, so in one of them I probably changed this locators. I will undo this change.

@viorelaioia viorelaioia force-pushed the viorelaioia:bug_1113662 branch from 93fc461 to f49ea8f Jan 16, 2015

@try-server-hook

This comment has been minimized.

Copy link

commented Jan 16, 2015

viorelaioia viorelaioia started tests. Results

@bebef1987

This comment has been minimized.

Copy link
Member

commented Jan 19, 2015

This test is failing for me with:

TEST-START | test_sms_with_attachments.py TestSmsWithAttachments.test_sms_send
TEST-UNEXPECTED-ERROR | test_sms_with_attachments.py TestSmsWithAttachments.test_sms_send | NoSuchElementException: NoSuchElementException: Unable to locate element: .loading-screen


Traceback (most recent call last):
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette/marionette_test.py", line 268, in run
    testMethod()
  File "/home/florinstrugariu/gaia/tests/python/gaia-ui-tests/gaiatest/tests/functional/messages/test_sms_with_attachments.py", line 33, in test_sms_send
    camera = activities_list.tap_camera()
  File "/home/florinstrugariu/gaia/tests/python/gaia-ui-tests/gaiatest/apps/system/regions/activities.py", line 57, in tap_camera
    camera.wait_for_loading_spinner_hidden()
  File "/home/florinstrugariu/gaia/tests/python/gaia-ui-tests/gaiatest/apps/camera/app.py", line 47, in wait_for_loading_spinner_hidden
    loading_spinner = self.marionette.find_element(*self._loading_screen_locator)
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette/marionette.py", line 1354, in find_element
    response = self._send_message('findElement', 'value', **kwargs)
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette/decorators.py", line 36, in _
    return func(*args, **kwargs)
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette/marionette.py", line 634, in _send_message
    self._handle_error(response)
  File "/home/florinstrugariu/.virtualenvs/gaia/local/lib/python2.7/site-packages/marionette/marionette.py", line 673, in _handle_error
    raise errors.NoSuchElementException(message=message, status=status, stacktrace=stacktrace)
TEST-INFO took 123878ms

SUMMARY
-------
passed: 0
failed: 1
todo: 0

@viorelaioia viorelaioia force-pushed the viorelaioia:bug_1113662 branch from f49ea8f to 5082fb5 Jan 23, 2015

@try-server-hook

This comment has been minimized.

Copy link

commented Jan 23, 2015

viorelaioia viorelaioia started tests. Results

JohanLorenzo added a commit that referenced this pull request Jan 27, 2015

Merge pull request #27115 from viorelaioia/bug_1113662
Bug 1113662 - [v2.2] Investigate test_sms_with_attachments tap_capture f...

@JohanLorenzo JohanLorenzo merged commit 06b1651 into mozilla-b2g:master Jan 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.