This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1122431 - [Stingray] UI-Transition - Change app modal dialog to TV U... #29286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean2449
force-pushed
the
Bug_1122431-dialog-box
branch
from
a13b7c2
to
7a1b13a
Compare
sean2449
force-pushed
the
Bug_1122431-dialog-box
branch
from
7a1b13a
to
8bc6121
Compare
sean2449
force-pushed
the
Bug_1122431-dialog-box
branch
from
8bc6121
to
08702ce
Compare
| }; | ||
|
|
||
| AppModalDialog.prototype.focus = function amd_show() { | ||
| // XXX: Focusing smart-button fails at the second time popup if we don't | ||
| // postpone it. We need to find the root cause. | ||
| setTimeout(function() { | ||
| document.activeElement.blur(); |
There was a problem hiding this comment.
I think we still need to blur the active element before focus this.element.
sean2449
force-pushed
the
Bug_1122431-dialog-box
branch
from
08702ce
to
b78b6df
Compare
sean2449
force-pushed
the
Bug_1122431-dialog-box
branch
from
b78b6df
to
702d221
Compare
sean2449
force-pushed
the
Bug_1122431-dialog-box
branch
from
702d221
to
6d9f2bf
Compare
sean2449
force-pushed
the
Bug_1122431-dialog-box
branch
from
6d9f2bf
to
f4d3171
Compare
| @@ -20,6 +20,10 @@ | |||
| exports.AppModalDialog = function AppModalDialog(app) { | |||
| this.app = app; | |||
| this.containerElement = app.element; | |||
| this.smartBubble = document.createElement('smart-bubbles'); | |||
| this.smartBubble.addEventListener('all-items-bubbled', function() { | |||
There was a problem hiding this comment.
The same problem, shouldn't we append dom elements that we want to bubble inside smart-bubbles? Or it's pretty weird to make it a dom component that have HTML tag of itself.
There was a problem hiding this comment.
Agree with rex. Should we put the smart bubble to view()??
mozilla-autolander-deprecated
added a commit
that referenced
this pull request
Apr 21, 2015
…log-box to mozilla-b2g:master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...I spec