This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 1158238 - [System] Add import activity #29718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinGrandon
force-pushed
the
bug_1158238_app_import_activity
branch
2 times, most recently
from
889ab66
to
d497816
Compare
| // Enable the addon by default. | ||
| navigator.mozApps.mgmt.setEnabled(addon, true); | ||
|
|
||
| activity.postResult({}); |
There was a problem hiding this comment.
I wonder if we should post anything useful here instead of an empty object. Can we post the addon object itself? Or at least the manifestURL.
There was a problem hiding this comment.
I usually just avoid it until we actually need something, but the manifestURL makes sense. Added that.
KevinGrandon
force-pushed
the
bug_1158238_app_import_activity
branch
from
d497816
to
6288639
Compare
KevinGrandon
force-pushed
the
bug_1158238_app_import_activity
branch
from
6288639
to
b511996
Compare
mozilla-autolander-deprecated
added a commit
that referenced
this pull request
Apr 27, 2015
…_app_import_activity to mozilla-b2g:master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=1158238