Bug 814632 - [Clock] Put a silent alarm screen underneath the oncall screen if the alarm goes off during a phone call r=timdream #6816

Merged
merged 1 commit into from Dec 5, 2012

Conversation

Projects
None yet
1 participant
Contributor

ian-liu commented Dec 5, 2012

Check onRing page is visible or not during init() state.
If it's hidden, don't the active alarm with ring/vibration.

Note: In this case, system::attention_screen have set the alarm screen visibility to false since there is an oncall screen showing. It will let alarm screen underneath the oncall screen.

@ian-liu ian-liu Bug 814632 - [Clock] Put a silent alarm screen underneath the oncall …
…screen if the alarm goes off during a phone call r=timdream
7157fb8
Contributor

ian-liu commented Dec 5, 2012

Got r+, let merge the pr.
We still need to deal with more visibility checks with bug 809087 and bug 817489.

@ian-liu ian-liu added a commit that referenced this pull request Dec 5, 2012

@ian-liu ian-liu Merge pull request #6816 from ian-liu/clock/Bug814632_silent_alarm_sc…
…reen_underneath_call_screen

Bug 814632 - [Clock] Put a silent alarm screen underneath the oncall screen if the alarm goes off during a phone call r=timdream
df38f79

@ian-liu ian-liu merged commit df38f79 into mozilla-b2g:master Dec 5, 2012

@timdream timdream added a commit that referenced this pull request Dec 7, 2012

@timdream timdream Revert "Merge pull request #6816 from ian-liu/clock/Bug814632_silent_…
…alarm_screen_underneath_call_screen"

This reverts commit df38f79, reversing
changes made to 1734754.
b866237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment