Bug 818354 - Disabling home button on locked screen while calling #6843

Merged
merged 1 commit into from Dec 6, 2012

Projects

None yet

2 participants

@albertopq
Member

No description provided.

@etiennesegonzac etiennesegonzac commented on an outdated diff Dec 6, 2012
apps/system/js/attention_screen.js
@@ -230,9 +230,9 @@ var AttentionScreen = {
},
// shrink the attention screen overlay to status bar
- // invoked when we get a "home" event
+ // invoked when we get a "home" event (and the screen is not locked)
@etiennesegonzac
etiennesegonzac Dec 6, 2012 collaborator

the comment is misleading since the function is invoked when screen is locked too.
we should probably add a comment below.

@albertopq albertopq merged commit ce6d344 into mozilla-b2g:master Dec 6, 2012
@timdream timdream added a commit that referenced this pull request Dec 12, 2012
@timdream timdream Revert "Merge pull request #6843 from albertopq/dialer-818354"
This reverts commit ce6d344, reversing
changes made to 2b436ac.
54e3e49
@basiclines basiclines added a commit to basiclines/gaia that referenced this pull request Dec 12, 2012
@timdream timdream Revert "Merge pull request #6843 from albertopq/dialer-818354"
This reverts commit ce6d344, reversing
changes made to 2b436ac.
bdae7cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment