Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bug 815501 - Handle undefined developer name and url in the app install dialog #6910

Merged
merged 1 commit into from Jan 9, 2013

Conversation

Projects
None yet
3 participants
Contributor

mnoorenberghe commented Dec 10, 2012

No description provided.

@etiennesegonzac etiennesegonzac commented on an outdated diff Dec 10, 2012

apps/system/test/unit/app_install_manager_test.js
});
- AppInstallManager.handleAppInstallPrompt(evt.detail);
- assert.equal('unknown', AppInstallManager.authorName.textContent);
- assert.equal('', AppInstallManager.authorUrl.textContent);
+ test('should tell if the developer is unknown 2', function() {
@etiennesegonzac

etiennesegonzac Dec 10, 2012

Contributor

nit -> 'should handle empty developer object properly' ?

Not a big fan of "2" ;)

Contributor

mnoorenberghe commented Dec 10, 2012

Fixed test description in f2b01c2

vingtetun added a commit that referenced this pull request Jan 9, 2013

Merge pull request #6910 from mnoorenberghe/815501-app-install-developer
Bug 815501 - Handle undefined developer name and url in the app install dialog

@vingtetun vingtetun merged commit 6aa968b into mozilla-b2g:master Jan 9, 2013

Contributor

mnoorenberghe commented Jan 9, 2013

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment