Bug 820778-reopened. Improve Performance in link and import lists of fri... #7084

Merged
merged 1 commit into from Dec 19, 2012

Projects

None yet

2 participants

@jmcanterafonseca
Contributor

@crdlc R?

Please check for possible regressions of image loader. My network connection is not good today and I'm not sure if images are loading properly or not

@crdlc crdlc and 1 other commented on an outdated diff Dec 19, 2012
apps/communications/contacts/js/fb/friends_list.js
@@ -27,6 +27,7 @@ fbFriends.List = (function() {
agroups.forEach(function(group) {
// New element appended
var ele = utils.templates.append(groupsList, {group: group}, fragment);
+ var list = ele.firstElementChild.nextElementSibling;
crdlc
crdlc Dec 19, 2012 Contributor

var list = ele.children[1], is it the same?

jmcanterafonseca
jmcanterafonseca Dec 19, 2012 Contributor

yes, that should work as the children array contains element nodes

Contributor
crdlc commented Dec 19, 2012

I need to check the code in my mobile in a couple of hours

Contributor
crdlc commented Dec 19, 2012

The images are loaded perfectly in import section and search

Contributor

changed by children[1] as requested

@crdlc crdlc merged commit ff651e8 into mozilla-b2g:master Dec 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment