Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bug 820028 - If a Facebook contact has several phone numbers only two ar... #7087

Merged
merged 1 commit into from Dec 19, 2012

Conversation

Projects
None yet
2 participants
Contributor

jmcanterafonseca commented Dec 19, 2012

...e imported

@crdlc crdlc commented on an outdated diff Dec 19, 2012

apps/communications/contacts/js/fb/fb_contact_utils.js
@@ -87,6 +87,20 @@ fb.setFriendPictureUrl = function(devContact, url) {
// Adapts data to the mozContact format names
fb.friend2mozContact = function(f) {
+
+ function normalizeFbPhoneNumber(phone) {
+ var out = phone.number;
+ if (phone.country_code && phone.number.indexOf('+') !== 0) {
@crdlc

crdlc Dec 19, 2012

Contributor

out.indexOf(.....

Contributor

crdlc commented Dec 19, 2012

The rest is perfect for me

Contributor

jmcanterafonseca commented Dec 19, 2012

comments have been addressed

@jmcanterafonseca jmcanterafonseca added a commit that referenced this pull request Dec 19, 2012

@jmcanterafonseca jmcanterafonseca Merge pull request #7087 from jmcanterafonseca/fix_tel
Bug 820028 - If a Facebook contact has several phone numbers only two ar...
e342b96

@jmcanterafonseca jmcanterafonseca merged commit e342b96 into mozilla-b2g:master Dec 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment