Bug 824705 - Data connection is lost on reboot if SIM PIN code is enabled #7232

Merged
merged 1 commit into from Dec 28, 2012

Conversation

Projects
None yet
2 participants
Contributor

fabi1cazenave commented Dec 28, 2012

https://bugzilla.mozilla.org/show_bug.cgi?id=824705

I’m afraid I had to rewrite most of the operator_variant.js file…

apps/system/js/operator_variant/operator_variant.js
+ mncRequest.onsuccess = function() {
+ iccSettings.mnc = parseInt(mncRequest.result[mncKey], 10) || 0;
+ callback();
+ };
@vingtetun

vingtetun Dec 28, 2012

Contributor

Why can't you simply nest them so the callback will be called only once?

@fabi1cazenave

fabi1cazenave Dec 28, 2012

Contributor

ugh. Yes of course.

apps/system/js/operator_variant/operator_variant.js
/* vim: set shiftwidth=2 tabstop=2 autoindent cindent expandtab: */
'use strict';
(function OperatorVariant() {
- var gNetwork = null;
- var cset = null;
+ var iccSettings = { mcc: -1, mnc: -1 };
@vingtetun

vingtetun Dec 28, 2012

Contributor

Let's declare that after the mozSettings check. No need to assign something that will be never used in some cases.

vingtetun added a commit that referenced this pull request Dec 28, 2012

Merge pull request #7232 from fabi1cazenave/pincode-fix
Bug 824705 - Data connection is lost on reboot if SIM PIN code is enabled

@vingtetun vingtetun merged commit 640173d into mozilla-b2g:master Dec 28, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment