Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bug 825592 - Followup 814460 - Add icon from Everything.me on Homescreen #7260

Merged
merged 1 commit into from Dec 31, 2012

Conversation

Projects
None yet
2 participants
Contributor

samjoch commented Dec 31, 2012

Followup 814460

@vingtetun vingtetun commented on an outdated diff Dec 31, 2012

apps/homescreen/js/bookmark.js
@@ -3,6 +3,12 @@
var Bookmark = function Bookmark(params) {
this.removable = true;
+ if( "iconable" in params ) {
@vingtetun

vingtetun Dec 31, 2012

Contributor

nit: " -> '

@vingtetun

vingtetun Dec 31, 2012

Contributor

if ('iconable' in params) {

(note the additional space after the if and not after the '(')

vingtetun added a commit that referenced this pull request Dec 31, 2012

Merge pull request #7260 from guiora/bug-825592
Bug 825592 - Followup 814460 - Add icon from Everything.me on Homescreen

@vingtetun vingtetun merged commit c33cdcf into mozilla-b2g:master Dec 31, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment