Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Ux 2013 01 04 cherry picked #7306

Merged
merged 33 commits into from Jan 7, 2013

Conversation

Projects
None yet
Contributor

samjoch commented Jan 7, 2013

  • Bug 803449 - Unidentifiable toggle in the notification bar
  • Bug 818216 - [Sounds] Sounds Unlock
  • Bug 823515 - Notification Time Stamp is too low
  • Bug 800016 - Updated volume overlay icons to latest design.
  • Bug 806963 - [Notifications] Different Icon Sizes used for 'System Update Available' and 'Downloading System Update' and the app is not to spec.

@vingtetun vingtetun commented on an outdated diff Jan 7, 2013

apps/system/js/quick_settings.js
@@ -9,7 +9,8 @@ var QuickSettings = {
init: function qs_init() {
var settings = window.navigator.mozSettings;
- if (!settings)
+ this.conn = window.navigator.mozMobileConnection;
@vingtetun

vingtetun Jan 7, 2013

Contributor

Why do you need to use this instead of |var conn| ?

@vingtetun vingtetun commented on an outdated diff Jan 7, 2013

apps/system/js/quick_settings.js
@@ -29,6 +30,24 @@ var QuickSettings = {
}
});
+ /*
+ * Monitor data network icon
+ */
+ this.conn.addEventListener('datachange', function() {
@vingtetun

vingtetun Jan 7, 2013

Contributor

nit: add a name yo your anonymous function.

@vingtetun vingtetun and 1 other commented on an outdated diff Jan 7, 2013

apps/system/style/quick_settings/quick_settings.css
}
#quick-settings > #quick-settings-data {
- background-image: url(images/data-off.svg);
+ background-image: url(images/data-off.png);
+}
+#quick-settings > #quick-settings-data[data-network="2G"] {
@vingtetun

vingtetun Jan 7, 2013

Contributor

Since this is an id you don't really need the |#quick-settings >| before. (same for the followings)

@samjoch

samjoch Jan 7, 2013

Contributor

You know what you are totally right ! Let me remove all the "#quick-settings > "

@vingtetun vingtetun and 1 other commented on an outdated diff Jan 7, 2013

apps/system/style/update_manager/update_manager.css
@@ -114,6 +115,8 @@ html, body {
}
#updates-download-dialog {
+ padding-bottom: 4.9rem;
+ padding-top: 0rem;
@vingtetun

vingtetun Jan 7, 2013

Contributor

nit: extra rem

@samjoch

samjoch Jan 7, 2013

Contributor

Should i use something like recess ?

@vingtetun vingtetun commented on an outdated diff Jan 7, 2013

apps/system/js/quick_settings.js
@@ -8,8 +8,9 @@ var QuickSettings = {
geolocationEnabled: false,
init: function qs_init() {
- var settings = window.navigator.mozSettings;
- if (!settings)
+ var settings = window.navigator.mozSettings,
+ conn = window.navigator.mozMobileConnection;
@vingtetun

vingtetun Jan 7, 2013

Contributor

Please do 2 separated |var foo = ...;| instead of this syntax.

jmcanterafonseca and others added some commits Dec 20, 2012

Bug 820145 - Update icons
Changes the edit icon into a edit mode type of icon.
Adds a compose icon as the old edit icon.
Adds an edit contact icon.
Bug 825017 - [B2G][FTE] The import Facebook contacts button now works…
… correctly

fixes

Fix

Display logic fix in fb-ftu button

Forget the wifi on startup of ftu

cleaning
Bug 826112 - record connected device by using asyncStorage
and restore the connection when bluetooth is turned on again.
Configure the prod payment provider (bug 824841)
This also removes the mock payment provider
that was in use only for testing.
Bug 826585 - [email/activesync] Deleting/moving messages causes them …
…to show up twice in the target folder; r=asuth, a=blocking-basecamp

vingtetun added a commit that referenced this pull request Jan 7, 2013

@vingtetun vingtetun merged commit 66221e0 into mozilla-b2g:master Jan 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment