[816152] Adding PUK management to FTU #7322

Merged
merged 1 commit into from Jan 9, 2013

Projects

None yet

3 participants

@fcampo
Collaborator
fcampo commented Jan 7, 2013

https://bugzilla.mozilla.org/show_bug.cgi?id=816152

Adding new screen for PUK code input, and error handling with different codes

code-r=? @borjasalguero
l10n-r=? @stasm

@fcampo
Collaborator
fcampo commented Jan 9, 2013

Adding @fabi1cazenave as reviewer for the lastest changes on strings, which affect Settings app

@borjasalguero borjasalguero commented on an outdated diff Jan 9, 2013
apps/communications/ftu/js/app.js
@@ -19,9 +20,15 @@ var AppManager = {
setTimeout(function() {
// For desktop
window.location.hash = '#';
- UIManager.splashScreen.classList.remove('show');
- UIManager.activationScreen.classList.add('show');
+ // UIManager.activationScreen.classList.add('show');
@borjasalguero
borjasalguero Jan 9, 2013 Mozilla-B2G member

Despite this part it's only for testing, I would remove code commented.

@borjasalguero borjasalguero commented on an outdated diff Jan 9, 2013
apps/communications/ftu/js/app.js
window.location.hash = '#languages';
+ // For testing PIN or PUK screens
+ // SimManager.showPinScreen();
@borjasalguero
borjasalguero Jan 9, 2013 Mozilla-B2G member

Same as above.

@fabi1cazenave fabi1cazenave commented on the diff Jan 9, 2013
apps/communications/ftu/js/navigation.js
simOption.classList.remove('disabled');
} else {
simOption.classList.add('disabled');
}
// If we have 3G or Wifi activate FB import
- if (WifiManager.api.connection.status === 'connected' || DataMobile.isDataAvailable) {
+ if (WifiManager.api.connection.status === 'connected' ||
+ DataMobile.isDataAvailable) {
@borjasalguero borjasalguero commented on an outdated diff Jan 9, 2013
apps/communications/ftu/js/ui.js
@@ -170,8 +207,11 @@ var UIManager = {
SimManager.unlock();
break;
// workaround for a number-passsword input
- case 'fake-sim-pin':
- this.pinInput.value = this.fakeSimPin.value;
+ case 'fake-pin-input':
+ case 'fake-puk-input':
+ case 'fake-newpin-input':
+ case 'fake-confirm-newpin-input':
+ this.fakeInputValues(event.target, event.charCode);
@borjasalguero
borjasalguero Jan 9, 2013 Mozilla-B2G member

I would rather to remove this cases from the switch and add directly like this.fakePinInput.addEventListener('keypress', this.fakeInputValues.bind(this)); and modify fakeInputValues in order to receive directly the event and create fakeInput, code vars.

@borjasalguero
Member

@fcampo The code looks great! Address the comments and I will test it again.

@borjasalguero
Member

@fcampo Add the reviewers in the commit and that's all! R+ ;)

@fcampo fcampo merged commit 2a3b7e8 into mozilla-b2g:master Jan 9, 2013
@fcampo fcampo deleted the fcampo:pukCode branch Jan 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment