Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bug 827331 - Long press is fired while slow panning (about contextmenu e... #7324

Merged
merged 1 commit into from Jan 9, 2013

Conversation

Projects
None yet
2 participants
Contributor

crdlc commented Jan 7, 2013

...vent) [r=vingtetun]

@vingtetun vingtetun commented on the diff Jan 7, 2013

apps/homescreen/js/grid.js
@@ -170,6 +171,11 @@ const GridManager = (function() {
break;
case 'contextmenu':
+ if (deltaX !== 0) {
+ evt.stopImmediatePropagation();
@vingtetun

vingtetun Jan 7, 2013

Contributor

Have you tested in on the device or only on desktop? 0px is easy on desktop but i remember that it was hard on a device

@vingtetun

vingtetun Jan 9, 2013

Contributor

@crdlc not sure you have seen my question? :)

@crdlc

crdlc Jan 9, 2013

Contributor

sorry I did not read it :( Yeah, I only tested it on Unagi. If you want I can install the branch in the device and I show you , ok?

@vingtetun

vingtetun Jan 9, 2013

Contributor

Just seen IRL that it seems good, thanks :)

@vingtetun vingtetun added a commit that referenced this pull request Jan 9, 2013

@vingtetun vingtetun Merge pull request #7324 from crdlc/bug-827331
Bug 827331 - Long press is fired while slow panning (about contextmenu e...
6eaab8f

@vingtetun vingtetun merged commit 6eaab8f into mozilla-b2g:master Jan 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment