Bug 827610 - Modify banner style to have variable size #7362

Merged
merged 1 commit into from Jan 10, 2013

Conversation

Projects
None yet
5 participants
Contributor

crh0716 commented Jan 8, 2013

https://bugzilla.mozilla.org/show_bug.cgi?id=827610

Modify the style to have variable size. Also remove duplicate banner style and link to the shared one.

Contributor

basiclines commented Jan 8, 2013

Seems pretty nice!
Did you test the modified applications?

Thx!

Contributor

crh0716 commented Jan 8, 2013

I've tested ev.me and clock and they work fine.

Contributor

basiclines commented Jan 8, 2013

r+ from my side so

Contributor

ian-liu commented Jan 9, 2013

It works for me. r+

Contributor

ranbena commented Jan 9, 2013

The padding in evme banner is wrong. Here's the fix EverythingMe/gaia@129da99

Arthur, I can't do a PR to your repo so can you simply do the change in your branch?

Contributor

crh0716 commented Jan 9, 2013

Ran, your fix has been mergerd. Thanks!

@vingtetun vingtetun added a commit that referenced this pull request Jan 10, 2013

@vingtetun vingtetun Merge pull request #7362 from crh0716/827610
Bug 827610 - Modify banner style to have variable size
15e6c92

@vingtetun vingtetun merged commit 15e6c92 into mozilla-b2g:master Jan 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment