Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Bug 841017 - [Email] Background does not scroll with content #8781

Merged
merged 1 commit into from

2 participants

@pivanov
Collaborator

Bug #841017

@KevinGrandon
Owner

@pivanov - I just have one nitpick here.

Because we're using multiple background layers here it causes an issue when you get to the bottom of the scrollable area as the parent has some kind of padding here.

If we want this, I think we need the background on a single layer, and to provide that layer with bottom padding.

Perhaps getting rid of the bottom-toolbar-spacer element will fix this.

@pivanov
Collaborator

I agree :)

@pivanov
Collaborator

very good idea Kevin :) thanks again
PR updated :)

@KevinGrandon KevinGrandon merged commit 69c9841 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 6 additions and 4 deletions.
  1. +0 −1  apps/email/index.html
  2. +6 −3 apps/email/style/folder-cards.css
View
1  apps/email/index.html
@@ -93,7 +93,6 @@ <h1 class="fld-folders-header-account-label"></h1>
<div class="scrollregion-below-header folder-scroller-region">
<div class="fld-folders-container">
</div>
- <div class="bottom-toolbar-spacer"></div>
</div>
<div class="fld-nav-toolbar bottom-toolbar">
<button class="fld-nav-settings-btn bottom-btn"></button>
View
9 apps/email/style/folder-cards.css
@@ -41,15 +41,18 @@
color: white;
}
-.folder-scroller-region,
+.fld-folders-container,
.acct-scroller-region {
- background-color: white;
- background: url(images/pattern.png) repeat left top #3a4446;
+ background: #3a4446 url(images/pattern.png);
background-size: auto auto, 100% 100%;
overflow-x: hidden;
overflow-y: auto;
}
+.fld-folders-container {
+ padding-bottom: 9.6rem;
+}
+
.folder-scroller-region.scrollregion-below-header,
.acct-scroller-region.scrollregion-below-header {
height: calc(100% - 5rem);
Something went wrong with that request. Please try again.