Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bug 841017 - [Email] Background does not scroll with content #8781

Merged
merged 1 commit into from Apr 5, 2013

Conversation

Projects
None yet
2 participants
Member

pivanov commented Mar 24, 2013

Bug #841017

Owner

KevinGrandon commented Apr 4, 2013

@pivanov - I just have one nitpick here.

Because we're using multiple background layers here it causes an issue when you get to the bottom of the scrollable area as the parent has some kind of padding here.

If we want this, I think we need the background on a single layer, and to provide that layer with bottom padding.

Perhaps getting rid of the bottom-toolbar-spacer element will fix this.

Member

pivanov commented Apr 5, 2013

I agree :)

Member

pivanov commented Apr 5, 2013

very good idea Kevin :) thanks again
PR updated :)

KevinGrandon added a commit that referenced this pull request Apr 5, 2013

Merge pull request #8781 from pivanov/bug-841017
Bug 841017 - [Email] Background does not scroll with content

@KevinGrandon KevinGrandon merged commit 69c9841 into mozilla-b2g:master Apr 5, 2013

1 check passed

default The Travis build passed
Details

KevinGrandon added a commit that referenced this pull request May 6, 2013

Merge pull request #8781 from pivanov/bug-841017
Bug 841017 - [Email] Background does not scroll with content(cherry picked from commit 69c9841)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment