Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Bug #858774 and #858776: Capitalization and drop HTTPS #9022

Closed
wants to merge 2 commits into from

2 participants

@bkerensa

internet should be capitalized "Internet" and drop HTTPS for FAQ in about.html

bkerensa added some commits
@bkerensa bkerensa Update fte.html
internet should be capitalized "Internet"
f716763
@bkerensa bkerensa Update about.html
Since Firefox OS FAQ is available via regular HTTP we should drop use of HTTPS... I know this is a trivial change but:

1. realistically no sensitive user info is shared on the FAQ
2. SSL is a computationally expensive protocol that users more power... So if we default to HTTP thats a greener practice.
f2f4102
@lodr lodr commented on the diff
apps/browser/about.html
@@ -20,7 +20,7 @@
<h1 data-l10n-id="browser">Browser</h1>
<ul>
<li><a data-l10n-id="support-about" href="http://support.mozilla.org/products/firefox-os">Support</a></li>
- <li><a data-l10n-id="faq-about" href="https://www.mozilla.org/firefox/mobile/faq/?os=firefox-os">FAQ</a></li>
+ <li><a data-l10n-id="faq-about" href="http://www.mozilla.org/firefox/mobile/faq/?os=firefox-os">FAQ</a></li>
@lodr Collaborator
lodr added a note

This is not related with the purpose of the fix and the secure option is safer for evident reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@lodr lodr commented on the diff
apps/costcontrol/fte.html
@@ -66,13 +66,13 @@ <h1 data-l10n-id="fte-welcome-title">Welcome</h1>
</header>
<section class="content">
<div class="authed-sim" aria-hidden="true">
- <h2 data-l10n-id="fte-authed-sim">Save money by keeping track of your phone and internet usage.</h2>
+ <h2 data-l10n-id="fte-authed-sim">Save money by keeping track of your phone and Internet usage.</h2>
@lodr Collaborator
lodr added a note

Text in the HTML means nothing. If you want to provide a fix, please modify the localization files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@lodr
Collaborator

Please, fix the PR and ask for review in the bug and I will merge your changes gladly.

@lodr lodr closed this
@bkerensa

There is no need for HTTPS for this link considering no data can be submitted from the end user. Further the fix should be in the sourced that way it can be L10n'ed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 5, 2013
  1. @bkerensa

    Update fte.html

    bkerensa authored
    internet should be capitalized "Internet"
  2. @bkerensa

    Update about.html

    bkerensa authored
    Since Firefox OS FAQ is available via regular HTTP we should drop use of HTTPS... I know this is a trivial change but:
    
    1. realistically no sensitive user info is shared on the FAQ
    2. SSL is a computationally expensive protocol that users more power... So if we default to HTTP thats a greener practice.
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 4 deletions.
  1. +1 −1  apps/browser/about.html
  2. +3 −3 apps/costcontrol/fte.html
View
2  apps/browser/about.html
@@ -20,7 +20,7 @@
<h1 data-l10n-id="browser">Browser</h1>
<ul>
<li><a data-l10n-id="support-about" href="http://support.mozilla.org/products/firefox-os">Support</a></li>
- <li><a data-l10n-id="faq-about" href="https://www.mozilla.org/firefox/mobile/faq/?os=firefox-os">FAQ</a></li>
+ <li><a data-l10n-id="faq-about" href="http://www.mozilla.org/firefox/mobile/faq/?os=firefox-os">FAQ</a></li>
@lodr Collaborator
lodr added a note

This is not related with the purpose of the fix and the secure option is safer for evident reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
<li><a data-l10n-id="credits-about" href="http://www.mozilla.org/credits/">Credits</a></li>
</ul>
<p data-l10n-id="trademark-about2">Browser and the Browser logos are trademarks of the Mozilla Foundation</p>
View
6 apps/costcontrol/fte.html
@@ -66,13 +66,13 @@ <h1 data-l10n-id="fte-welcome-title">Welcome</h1>
</header>
<section class="content">
<div class="authed-sim" aria-hidden="true">
- <h2 data-l10n-id="fte-authed-sim">Save money by keeping track of your phone and internet usage.</h2>
+ <h2 data-l10n-id="fte-authed-sim">Save money by keeping track of your phone and Internet usage.</h2>
@lodr Collaborator
lodr added a note

Text in the HTML means nothing. If you want to provide a fix, please modify the localization files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
</div>
<div class="nonauthed-sim" aria-hidden="true">
- <h2 data-l10n-id="fte-nonauthed-sim">Save money by keeping track of your internet usage.</h2>
+ <h2 data-l10n-id="fte-nonauthed-sim">Save money by keeping track of your Internet usage.</h2>
</div>
<div class="no-sim" aria-hidden="true">
- <h2 data-l10n-id="fte-no-sim">Get clear information about how much internet you're using.</h2>
+ <h2 data-l10n-id="fte-no-sim">Get clear information about how much Internet you're using.</h2>
</div>
<p data-l10n-id="fte-sim-info2" class="info">Information shown on usage comes directly from this device. Check with your mobile service provider for detailed account information.</p>
</section>
Something went wrong with that request. Please try again.