This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Bug 845110 - Fix margins and font size in edit calendar event ui #9025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samjoch Updated UI. Also adding @lightsofapollo since we removed seconds from events in doing this which is a more fundamental calendar change. |
|
@gaye Why removing seconds? They are technically part of the spec for time inputs... I feel like we have a lot of inconsistencies around time and the way to fix those is with an overlay above the actual time input. |
|
@lightsofapollo So the deal was that the mockup I saw here https://bug845110.bugzilla.mozilla.org/attachment.cgi?id=718753 had seconds removed from the input, so I figured they should be pulled at the model/data layer too. We could hide seconds in the input UI and keep them at the data layer though. Does that seem better? |
| * | ||
| * @param {String} value 23:20:50.52, 17:39:57. | ||
| * @return {Object} { hours: 23, minutes: 20, seconds: 50 }. | ||
| * @return {Object} { hours: 23, minutes: 20, seconds: 0 }. |
There was a problem hiding this comment.
why have seconds in docs ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.