Skip to content

Bug 845110 - Fix margins and font size in edit calendar event ui #9025

Closed
wants to merge 1 commit into from

2 participants

@gaye
Mozilla-B2G member
gaye commented Apr 5, 2013

No description provided.

@gaye
Mozilla-B2G member
gaye commented Apr 9, 2013

@samjoch Updated UI. Also adding @lightsofapollo since we removed seconds from events in doing this which is a more fundamental calendar change.

@lightsofapollo

@gaye Why removing seconds? They are technically part of the spec for time inputs... I feel like we have a lot of inconsistencies around time and the way to fix those is with an overlay above the actual time input.

@gaye
Mozilla-B2G member
gaye commented Apr 15, 2013

@lightsofapollo So the deal was that the mockup I saw here https://bug845110.bugzilla.mozilla.org/attachment.cgi?id=718753 had seconds removed from the input, so I figured they should be pulled at the model/data layer too. We could hide seconds in the input UI and keep them at the data layer though. Does that seem better?

@lightsofapollo lightsofapollo and 1 other commented on an outdated diff Apr 22, 2013
apps/calendar/js/utils/input_parser.js
*
* @param {String} value 23:20:50.52, 17:39:57.
- * @return {Object} { hours: 23, minutes: 20, seconds: 50 }.
+ * @return {Object} { hours: 23, minutes: 20, seconds: 0 }.

why have seconds in docs ?

@gaye
Mozilla-B2G member
gaye added a note Apr 23, 2013

Will remove!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@gaye gaye closed this Jan 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.