Bug 859296 - [Building Blocks] Update styles for "input area" #9042

Merged
merged 1 commit into from Apr 11, 2013

Conversation

Projects
None yet
2 participants
Member

rnowm commented Apr 8, 2013

No description provided.

Member

borjasalguero commented Apr 9, 2013

@rnowm We should include 'attach' icon and the structure for it. Wdyt?

@borjasalguero borjasalguero commented on an outdated diff Apr 10, 2013

shared/style/input_areas.css
height: 3rem;
- border: 0.1rem solid #ababab;
- background: #fff url(input_areas/images/ui/shadow-search.png) repeat-x left top;
+ border: none;
+ background: #fff;
+ border: none;
@borjasalguero

borjasalguero Apr 10, 2013

Member

Property repeated. Please remove it.

@borjasalguero borjasalguero commented on an outdated diff Apr 10, 2013

shared/style/input_areas.css
+ font-size: 0;
+ background: url(input_areas/images/ui/separator.png) no-repeat 100% 50%,
+ url(input_areas/images/ui/background.png) repeat-x 0 100%;
+ background-size: auto 100%;
+ border-radius: 0;
+ margin: 0;
+ padding: 0;
+ margin: 0;
+ position: relative;
+}
+form[role="search"] button.icon:before {
+ content: "";
+ position: absolute;
+ width: 3rem;
+ height: 3.7rem;
+ background: transparent center center no-repeat;
@borjasalguero

borjasalguero Apr 10, 2013

Member

'center' twice?

Member

borjasalguero commented Apr 10, 2013

In 'Contacts App', in 'search' feature, there are styles not updated when focusing in the field (old styles appears). Please check

Member

borjasalguero commented Apr 10, 2013

@rnowm Review finished! Please address the comments. Gracias!

Member

rnowm commented Apr 11, 2013

@borjasalguero I've fixed your comments.

Member

rnowm commented Apr 11, 2013

There's a bug related to the Search field in Contacts. It has nothing to see with the input Building Blocks.
https://bugzilla.mozilla.org/show_bug.cgi?id=859725
I'll fix it now.

@borjasalguero borjasalguero pushed a commit that referenced this pull request Apr 11, 2013

Francisco Borja Salguero Castellano Merge pull request #9042 from rnowm/input-form
Bug 859296 - [Building Blocks] Update styles for "input area"
20c9d5a

@borjasalguero borjasalguero merged commit 20c9d5a into mozilla-b2g:master Apr 11, 2013

1 check failed

default The Travis build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment