Bug 859436 - Add l10n id to the elements. r=dkuo, a=tef+ #9053

Merged
merged 1 commit into from Apr 18, 2013

2 participants

@dominickuo

@crh0716 I just noticed that in SubListView.activate() there are also unknown l10n strings need to handle, because when users are in album content page, if the language switches the unknown strings in SubListView also need to be updated, I am still reviewing the rest parts and feel free to revise that part first, thanks!

@dominickuo dominickuo commented on an outdated diff Apr 18, 2013
apps/music/js/music.js
@@ -1355,6 +1413,15 @@ var TabBar = {
init: function tab_init() {
this.option = '';
this.view.addEventListener('click', this);
+
+ this.playlistArray.localize = function() {
+ this.forEach(function(playList) {
+ var metadata = playList.metadata;
@dominickuo
dominickuo added a line comment Apr 18, 2013

@crh0716 Can you successfully launch music app with this updated patch? cause I got music app shows the progress bar forever and mix page does not show anything.

Since the last object of the playlistArray is null, you should check playList first then you can get playList.metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@crh0716 crh0716 merged commit c938a4b into mozilla-b2g:master Apr 18, 2013

1 check was pending

Details default The Travis build is in progress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment