Bug_858449:[SMS] Contact search list is not clearing when backspace quic... #9063

Closed
wants to merge 15 commits into from
sharfudheen.parambil Bug_858449:[SMS] Contact search list is not clearing when backspace q…
…uickly r=borjasalguero
5921180
@rwaldron rwaldron commented on an outdated diff Apr 9, 2013
apps/sms/js/thread_ui.js
@@ -983,6 +983,10 @@ var ThreadUI = {
}
Contacts.findByString(filterValue, function gotContact(contacts) {
+ var string = this.recipient.value;
+ if (!string) {
+ return;
+ }
@rwaldron
rwaldron added a note Apr 9, 2013

nit: every line is incorrectly indented.

If the value is only being used once, skip the assignment. Also, this will return if the value is 0

// Early return if the input value has been cleared
if (this.recipient.value === '') {
  return;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
basiclines and others added some commits Apr 4, 2013
@leob2g leob2g closed this Apr 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment