Bug 857942:[SMS] Select all button enabled in edit screen during new …
Why dont move only once before IF clause?
These are different calls:
My fault! I read the same Object name.
As a new message it's handled by 'onMessageReceived', I would fix there the bug. Here you have the scenarios:
@borjasalguero This issue fix is for two cases
1.If we are in particular Thread edit screen and got a new message then we need to enable "Select all".This case is handled by adding ThreadUI.checkList()
2.If we are in ThreadList edit screen and got a new message then we need to enable "Select all".For this case to handle added ThreadListUI.checkInputs()
I don't believe this should be in the activity handler. It's UI code that should be handled in the respective files (ThreadUI and ThreadListUI), they should be responsible for updating their UI at certain points.
I think we could add ThreadUI.checkList() in ThreadUI.appendMessage, checking if we are in edit mode or not (with the hash for example) or, at least, in onMessageReceived method.
There's another PR fixing the same issues #9056 which takes that approach, and includes some tests. Maybe there was a lack of sync between devs when fixing the bug?
Please assign the bug to yoursleves when you start to work on it so other devs won't work on the same :)
@fcampo +1 to #9056
Please add a test-case for this feature. @janjongboom has created other patch as well, could you sync in order to get only one PR to be reviewed? Thanks!
I will check this with your comments given
As far as I know #9056 now covers all the cases also covered in this issue.
I have done the changes with the comments given by you.I will test the patch once and upload it.