Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Bug 858722 - Fixing the busted permissions panel of the settings app. #9065

Merged
merged 1 commit into from

3 participants

Etienne Segonzac Sam Joch Fabien Cazenave
Etienne Segonzac
Collaborator

No description provided.

apps/settings/js/apps.js
@@ -9,7 +9,7 @@ var ApplicationsList = {
_permissionsTable: null,
- container: document.querySelector('#appPermissions > ul'),
+ container: document.querySelector('#appPermissions > div > ul:first-child'),
Sam Joch Collaborator
samjoch added a note

its a querySelector you don't need ul:first-child a ul is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Etienne Segonzac
Collaborator

Addressed @samjoch 's comment. We should land this sooner rather than later, ping @fabi1cazenave.

Fabien Cazenave fabi1cazenave merged commit 782e588 into from
Etienne Segonzac etiennesegonzac deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  apps/settings/js/apps.js
2  apps/settings/js/apps.js
View
@@ -9,7 +9,7 @@ var ApplicationsList = {
_permissionsTable: null,
- container: document.querySelector('#appPermissions > ul'),
+ container: document.querySelector('#appPermissions > div > ul'),
detailTitle: document.querySelector('#appPermissions-details > header > h1'),
developerHeader: document.getElementById('developer-header'),
developerInfos: document.getElementById('developer-infos'),
Something went wrong with that request. Please try again.