Bug 858722 - Fixing the busted permissions panel of the settings app. #9065

Merged
merged 1 commit into from Apr 11, 2013

Projects

None yet

3 participants

@etiennesegonzac

No description provided.

@samjoch samjoch commented on an outdated diff Apr 9, 2013
apps/settings/js/apps.js
@@ -9,7 +9,7 @@ var ApplicationsList = {
_permissionsTable: null,
- container: document.querySelector('#appPermissions > ul'),
+ container: document.querySelector('#appPermissions > div > ul:first-child'),
@samjoch
samjoch Apr 9, 2013

its a querySelector you don't need ul:first-child a ul is enough.

@etiennesegonzac

Addressed @samjoch 's comment. We should land this sooner rather than later, ping @fabi1cazenave.

@fabi1cazenave fabi1cazenave merged commit 782e588 into mozilla-b2g:master Apr 11, 2013

1 check failed

Details default The Travis build failed
@etiennesegonzac etiennesegonzac deleted the etiennesegonzac:bug-858722-settings-permissions-fix branch Feb 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment