Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bug 859575 - [Settings] Toggling APM can result in the checkbox remaining disabled #9072

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

mschwart commented Apr 9, 2013

Change-Id: I78086418f3cd26be9cdaa099a9e5f41476cb3ed9

Toggle airplane mode using the new settings value
Change-Id: I78086418f3cd26be9cdaa099a9e5f41476cb3ed9

@etiennesegonzac etiennesegonzac commented on the diff Apr 11, 2013

apps/settings/js/airplane_mode.js
@@ -121,7 +121,7 @@ var AirplaneMode = {
self._ops = 0;
self._doNotify = true;
- if (value) {
+ if (value.settingValue) {
@etiennesegonzac

etiennesegonzac Apr 11, 2013

Contributor

please rename the value parameter e or evt, makes it a lot easier to read :)

@etiennesegonzac

etiennesegonzac Apr 11, 2013

Contributor

and maybe add a var value = e.settingValue; at the beginning of the function, this way it fixes the issue for the self.status = value too.

@mschwart

mschwart Apr 11, 2013

Contributor

Going with e to be consistent with the naming convention of the file and removing self.status which is unused. Patch incoming

@mschwart mschwart closed this Jul 3, 2014

@mschwart mschwart deleted the mschwart:bug859575 branch Jul 3, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment