Fix expanding timezone into the future #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see there is a test failure. I'll fix it and then get back to you :) |
|
latest: timezone iterator & first iteration x 18,143 ops/sec ±0.74% (99 runs sampled) Heh- there should be some way to fail the tests if X test is more then N% slower then the previous version... I will see what I can come up with so we don't miss this kind of stuff. |
lightsofapollo
added a commit
that referenced
this pull request
May 22, 2013
Fix expanding timezone into the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure timezone expansion is actually saved. Not doing this will do the whole expansion for each year. Since these are internal details and you are working on a new expansion engine, it probably doesn't make sense to add tests. r? @lightsofapollo