Skip to content

Commit 12e5f7e

Browse files
committed
Bug 1991998 - Add telemetry to snackbar and undo button for deleting history item(s) [part 3] r=android-reviewers,boek
Differential Revision: https://phabricator.services.mozilla.com/D267124
1 parent 0889a9f commit 12e5f7e

File tree

2 files changed

+32
-1
lines changed

2 files changed

+32
-1
lines changed

mobile/android/fenix/app/metrics.yaml

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5691,6 +5691,32 @@ history:
56915691
notification_emails:
56925692
- android-probes@mozilla.com
56935693
expires: never
5694+
delete_snackbar_shown:
5695+
type: event
5696+
description: |
5697+
A delete snackbar was shown after one or more history items were deleted.
5698+
bugs:
5699+
- https://bugzilla.mozilla.org/show_bug.cgi?id=1991998
5700+
data_reviews:
5701+
- https://phabricator.services.mozilla.com/D267124
5702+
data_sensitivity:
5703+
- interaction
5704+
notification_emails:
5705+
- android-probes@mozilla.com
5706+
expires: never
5707+
delete_snackbar_undo_clicked:
5708+
type: event
5709+
description: |
5710+
The user clicked the undo button in a history delete snackbar.
5711+
bugs:
5712+
- https://bugzilla.mozilla.org/show_bug.cgi?id=1991998
5713+
data_reviews:
5714+
- https://phabricator.services.mozilla.com/D267124
5715+
data_sensitivity:
5716+
- interaction
5717+
notification_emails:
5718+
- android-probes@mozilla.com
5719+
expires: never
56945720

56955721
recently_closed_tabs:
56965722
opened:

mobile/android/fenix/app/src/main/java/org/mozilla/fenix/library/history/HistoryFragment.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,11 +261,16 @@ class HistoryFragment : LibraryPageFragment<History>(), UserInteractionHandler,
261261
val browserStore = requireComponents.core.store
262262
val historyStorage = requireComponents.core.historyStorage
263263

264+
GleanHistory.deleteSnackbarShown.record(NoExtras())
265+
264266
CoroutineScope(Dispatchers.Main).allowUndo(
265267
view = requireActivity().getRootView()!!,
266268
message = getMultiSelectSnackBarMessage(items),
267269
undoActionTitle = getString(R.string.snackbar_deleted_undo),
268-
onCancel = { undo(appStore = appStore, items = items) },
270+
onCancel = {
271+
undo(appStore = appStore, items = items)
272+
GleanHistory.deleteSnackbarUndoClicked.record(NoExtras())
273+
},
269274
operation = {
270275
delete(
271276
browserStore = browserStore,

0 commit comments

Comments
 (0)