Skip to content

Commit c16c263

Browse files
Alexandre Lissylissyx
authored andcommitted
Bug 1853108 - Enable Crash Pull on nightly r=gcp,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D251017
1 parent 9b629fb commit c16c263

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

modules/libpref/init/StaticPrefList.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1407,13 +1407,12 @@
14071407
mirror: always
14081408

14091409
# Control whether we enable the feature of crash pull at all
1410-
# Disabled by default for now until further notice
14111410
- name: browser.crashReports.crashPull
14121411
type: bool
1413-
value: false
1412+
value: @IS_NIGHTLY_BUILD@
14141413
mirror: always
14151414

1416-
# Should we prompt the user to send targetted crash report requested by devs?
1415+
# Should we prompt the user to send targeted crash report requested by devs?
14171416
- name: browser.crashReports.requestedNeverShowAgain
14181417
type: bool
14191418
value: false

toolkit/components/crashes/tests/xpcshell/test_remote_settings_crash_pull_nightly.js

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33

44
"use strict";
55

6-
/* const { AppConstants } = ChromeUtils.importESModule(
6+
const { AppConstants } = ChromeUtils.importESModule(
77
"resource://gre/modules/AppConstants.sys.mjs"
8-
); */
8+
);
99

1010
const { RemoteSettingsCrashPull } = ChromeUtils.importESModule(
1111
"resource://gre/modules/RemoteSettingsCrashPull.sys.mjs"
@@ -19,12 +19,11 @@ add_task(function test_pref_value() {
1919
const prefValue = Services.prefs.getBoolPref(
2020
"browser.crashReports.crashPull"
2121
);
22-
// Disabled by default until further notice
23-
/* if (AppConstants.NIGHTLY_BUILD) {
22+
if (AppConstants.NIGHTLY_BUILD) {
2423
Assert.ok(prefValue, "RemoteSettingsCrashPull pref enabled on nightly");
25-
} else { */
26-
Assert.ok(!prefValue, "RemoteSettingsCrashPull pref disabled on nightly");
27-
/* } */
24+
} else {
25+
Assert.ok(!prefValue, "RemoteSettingsCrashPull pref disabled on nightly");
26+
}
2827
});
2928

3029
add_task(function test_pref_disabled() {

0 commit comments

Comments
 (0)