Bug 1975980 - fix test failures due to the dom.security.https_first preference being inconsistently set, r=jmaher,necko-reviewers,sunil.

Differential Revision: https://phabricator.services.mozilla.com/D256282

Author: fqueze

dom/manifest/test/browser_ManifestObtainer_obtain.js

@@ -1,7 +1,13 @@
 "use strict";
 
-Services.prefs.setBoolPref("dom.manifest.enabled", true);
-Services.prefs.setBoolPref("dom.security.https_first", false);
+add_setup(async function () {
+  await SpecialPowers.pushPrefEnv({
+    set: [
+      ["dom.manifest.enabled", true],
+      ["dom.security.https_first", false],
+    ],
+  });
+});
 
 const { ManifestObtainer } = ChromeUtils.importESModule(
   "resource://gre/modules/ManifestObtainer.sys.mjs"

dom/manifest/test/browser_Manifest_install.js

@@ -39,6 +39,12 @@ function generateHash(aString, hashAlg) {
 
 const MANIFESTS_DIR = PathUtils.join(PathUtils.profileDir, "manifests");
 
+add_setup(async function () {
+  await SpecialPowers.pushPrefEnv({
+    set: [["dom.security.https_first", false]],
+  });
+});
+
 add_task(async function () {
   const tabOptions = { gBrowser, url: makeTestURL() };
 

netwerk/test/browser/browser_test_favicon.js

@@ -11,7 +11,10 @@ add_task(async function () {
   const pageUrl =
     "http://example.com/browser/netwerk/test/browser/file_favicon.html";
   await SpecialPowers.pushPrefEnv({
-    set: [["network.cookie.cookieBehavior", 1]],
+    set: [
+      ["network.cookie.cookieBehavior", 1],
+      ["dom.security.https_first", false],
+    ],
   });
 
   let promise = TestUtils.topicObserved("cookie-rejected", subject => {