Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Modernize platform-health #29
I assume this will take few days to over a week.
The work will happen in https://github.com/armenzg/platform-health/tree/separate
I've decided to separate the backend/frontend code into their own directories and boilerplate.
This will make it easier to move the forward the frontend without breaking the backend.
This all steams from that I tried to include react-metrics-graphics (for a frontend issue) and I started getting backend production-specific issues (#21 (comment)).
I was hoping that switching to Neutrino for both parts (backend and frontend) would make it easier to add new packages but the build complexity of webpack.config.babel.js and app.js has proven challenging.
If any of you have sample project I could look at to determine project layout it would be great.
I'm going to take a step back to evaluate if we can avoid separating the project into two.
If I can't I will separate frontend and backend into different repositories since it makes the deployment story with Heroku nicer. I will explain why.
Heroku only likes one Procfile per repository and only 1 web process, thus, requiring two different apps and pushing subtrees.
The document I followed:
Side notes with regards making the static buildpack to work:
From reading this:
Configured the Heroku remote:
Added the right buildpacks:
Added static.json and removed the Procfile.
@stuartphilp since I'm going to split and rename the repository, can we rename the project to
Few technical details (kudos here to @eliperelman):
I have the backend running here:
I have the frontend running based on data from the backend instance:
I need to fix the routing, status of benchmarks, the favicon and few other minor things.
The frontend is working and running against the official backend:
On Monday, as preparatory steps, I would like to switch the 'platform-health' GH repo to be 'firefox-health-dashboard'. I will need to make the 'platform-health' Heroku app point to the renamed repository.
For now, I won't rename the Heroku app to firefox-health-dashboard since it would break the domain.
I've landed the backend and frontend changes.
I've adjusted a couple of variables in the Heroku platform-health app to point to the backend and to deploy a static app.
We now have 2 fx-health pipelines. One for the frontend and one for the backend.
The FE now loads a bit faster than the previous set up (2-3 seconds).
Here’s the timing of Heroku FE to Heroku backend (the refactoring work):