New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Add i2c enabler to make-prep.sh #886

Merged
merged 1 commit into from Apr 19, 2018

Conversation

Projects
None yet
4 participants
@rzr
Contributor

rzr commented Apr 12, 2018

Should work with default config.txt where line is commented.

This is needed for building generic-sensors-addons:

https://discourse.mozilla.org/t/creating-i2c-add-on/26696/4

Change-Id: Ifb8006ded46ce78e537b1a5bf74453fcd635abb8
Signed-off-by: Philippe Coval philippe.coval@osg.samsung.com

@codecov-io

This comment has been minimized.

codecov-io commented Apr 12, 2018

Codecov Report

Merging #886 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #886      +/-   ##
==========================================
+ Coverage   77.08%   77.08%   +<.01%     
==========================================
  Files          87       87              
  Lines        3783     3780       -3     
  Branches      506      504       -2     
==========================================
- Hits         2916     2914       -2     
+ Misses        794      793       -1     
  Partials       73       73
Impacted Files Coverage Δ
src/rules-engine/effects/PulseEffect.js 100% <0%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1903910...cf72769. Read the comment docs.

@mrstegeman mrstegeman requested a review from dhylands Apr 12, 2018

@mrstegeman mrstegeman added the review label Apr 13, 2018

@rzr

This comment has been minimized.

Contributor

rzr commented Apr 13, 2018

@dhylands

dhylands requested changes Apr 13, 2018 edited

This doesn't enable i2c by default, was that the intention? When I run make-prep.sh to make an image, the default options are what is used on the images that we create.

@@ -283,6 +317,7 @@ main() {
echo " IMG_FILENAME = ${IMG_FILENAME}"
echo " PREP_FILENAME = ${PREP_FILENAME}"
echo "ENABLE_CONSOLE = ${ENABLE_CONSOLE}"
echo "ENABLE_I2C = ${ENABLE_I2C}"

This comment has been minimized.

@dhylands

dhylands Apr 13, 2018

Contributor

nit: The = are lined up on the other prints

@rzr

This comment has been minimized.

Contributor

rzr commented Apr 13, 2018

If you're ok to enable i2c in default images, that will be great, then I will update patch to replace by --no-i2c option to disable it.

@dhylands

This comment has been minimized.

Contributor

dhylands commented Apr 13, 2018

Yeah - I think that makes sense. It won't go out in the 0.4.0 release, but I don't see any reason why it shouldn't be enabled by default.

rzr added a commit to TizenTeam/gateway that referenced this pull request Apr 14, 2018

install: Enable I2C in image using make-prep.sh
It should work with default config.txt where line is commented.

This is helpful for using generic-sensors-addons:

https://discourse.mozilla.org/t/creating-i2c-add-on/26696/4

URL: mozilla-iot#886
Change-Id: Ifb8006ded46ce78e537b1a5bf74453fcd635abb8
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
install: Enable I2C in image using make-prep.sh
It should work with default config.txt where line is commented.

This is helpful for using generic-sensors-addons:

https://discourse.mozilla.org/t/creating-i2c-add-on/26696/4

URL: #886
Change-Id: Ifb8006ded46ce78e537b1a5bf74453fcd635abb8
Signed-off-by: Philippe Coval <philippe.coval@osg.samsung.com>
@rzr

This comment has been minimized.

Contributor

rzr commented Apr 17, 2018

Hi, I checked on master (also with --no-i2c), so it should be safe to merge for v0.4.1

@dhylands dhylands merged commit f211fae into mozilla-iot:master Apr 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the review label Apr 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment