Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import mozilla-mobile/fenix quarantine. #89

Merged
merged 12 commits into from
Oct 24, 2019
Merged

Import mozilla-mobile/fenix quarantine. #89

merged 12 commits into from
Oct 24, 2019

Conversation

mozilla-l10n-automation-bot
Copy link
Contributor

n/t

mcarare and others added 5 commits September 25, 2019 10:34
@mcarare
For #1383 Added tab title to close button content description
d037530 
X-Channel-Revision: [master] mozilla-mobile/android-components@6fee87d
X-Channel-Converted-Revision: [master] mozilla-mobile/fenix@bfe8bf4
X-Channel-Revision: [master] mozilla-mobile/firefox-tv@e8ccd59
X-Channel-Revision: [master] MozillaReality/FirefoxReality@55524ba
X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@d94d176
@sblatz
For #5567: Removes search shortcuts button (#5739)
517f52b 
* For #5567: Removes search shortcut button

* No issue: Simplifies logic for displaying shortcuts

X-Channel-Revision: [master] mozilla-mobile/android-components@6fee87d
X-Channel-Converted-Revision: [master] mozilla-mobile/fenix@785b8b9
X-Channel-Revision: [master] mozilla-mobile/firefox-tv@e8ccd59
X-Channel-Revision: [master] MozillaReality/FirefoxReality@55524ba
X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@d94d176
@sblatz
For #5742: Adds strings (#5743)
b6a235d 
X-Channel-Revision: [master] mozilla-mobile/android-components@6fee87d
X-Channel-Converted-Revision: [master] mozilla-mobile/fenix@097d7c2
X-Channel-Revision: [master] mozilla-mobile/firefox-tv@e8ccd59
X-Channel-Revision: [master] MozillaReality/FirefoxReality@55524ba
X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@d94d176
@sblatz
For mozilla-l10n#514 & #5742: Updates "launch links in private tab" …
a481f25 
…functionality (#5721)

* For mozilla-l10n#514 & #5742: Updates "launch links in private tab" functionality

* Fixes comments

X-Channel-Revision: [master] mozilla-mobile/android-components@6fee87d
X-Channel-Converted-Revision: [master] mozilla-mobile/fenix@371e2ac
X-Channel-Revision: [master] mozilla-mobile/firefox-tv@e8ccd59
X-Channel-Revision: [master] MozillaReality/FirefoxReality@55524ba
X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@d94d176
@mcarare
For #3604 Snackbar messages for closing tabs use closed instead of de…
644324a 
…leted

X-Channel-Revision: [master] mozilla-mobile/android-components@6fee87d
X-Channel-Converted-Revision: [master] mozilla-mobile/fenix@1c6aefd
X-Channel-Revision: [master] mozilla-mobile/firefox-tv@e8ccd59
X-Channel-Revision: [master] MozillaReality/FirefoxReality@55524ba
X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@d94d176
Delphine
Delphine requested changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@Delphine Delphine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sblatz : I see you landed these strings, could you please help to update them as per the comments so I can later expose them to localization?
thanks!

mozilla-mobile/fenix/app/src/main/res/values/strings.xml Outdated
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<!-- App name for private browsing mode, only the "(Private)" portion should be localized. -->
<string name="app_name_private">Firefox Preview (Private)</string>
<string name="app_name_private">Private Firefox Preview</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a string ID update if localizers are to be made aware they need to update this string

mozilla-mobile/fenix/app/src/main/res/values/strings.xml
@@ -173,6 +171,8 @@
<!-- Preference for developers -->
<string name="preferences_remote_debugging">Remote debugging via USB</string>
<!-- Preference title for switch preference to show search suggestions -->
<string name="preferences_show_search_shortcuts">Show search shortcuts</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment should be updated to "(...)show search shortcuts".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

sblatz added a commit to sblatz/fenix that referenced this pull request Oct 21, 2019
@sblatz
No issue: Fixes string issues for l10n
fb52b11 
Issues found here: mozilla-l10n/android-l10n#89
@sblatz sblatz mentioned this pull request Oct 21, 2019
Merged
5 tasks
sblatz added a commit to sblatz/fenix that referenced this pull request Oct 21, 2019
@sblatz
No issue: Fixes string issues for l10n
a89a3bc 
Issues found here: mozilla-l10n/android-l10n#89
sblatz added a commit to sblatz/fenix that referenced this pull request Oct 23, 2019
@sblatz
No issue: Fixes string issues for l10n
26e76e4 
Issues found here: mozilla-l10n/android-l10n#89
@sblatz
No issue: Fixes string issues for l10n (#6158)
6e20c1f 
Issues found here: mozilla-l10n#89
X-Channel-Revision: [master] mozilla-mobile/android-components@6fee87d
X-Channel-Converted-Revision: [master] mozilla-mobile/fenix@2cba624
X-Channel-Revision: [master] mozilla-mobile/firefox-tv@e8ccd59
X-Channel-Revision: [master] MozillaReality/FirefoxReality@55524ba
X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@d94d176
sblatz added a commit to mozilla-mobile/fenix that referenced this pull request Oct 24, 2019
@sblatz
No issue: Fixes string issues for l10n (#6158)
2cba624 
Issues found here: mozilla-l10n/android-l10n#89
@ekager
For #5544: Bare Minimum Logins UI
440410c 
X-Channel-Revision: [master] mozilla-mobile/android-components@6fee87d
X-Channel-Converted-Revision: [master] mozilla-mobile/fenix@f49331d
X-Channel-Revision: [master] mozilla-mobile/firefox-tv@e8ccd59
X-Channel-Revision: [master] MozillaReality/FirefoxReality@55524ba
X-Channel-Revision: [master] mozilla-lockwise/lockwise-android@d94d176
Delphine
Delphine approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@Delphine Delphine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good now :)
thanks!

@Delphine Delphine merged commit 21ac8c9 into mozilla-l10n:master Oct 24, 2019
mcarare pushed a commit to mcarare/fenix that referenced this pull request Oct 29, 2019
@sblatz @mcarare
No issue: Fixes string issues for l10n (mozilla-mobile#6158)
65b55dc 
Issues found here: mozilla-l10n/android-l10n#89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sblatz sblatz sblatz left review comments

@Delphine Delphine Delphine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mozilla-l10n-automation-bot @Delphine @sblatz @mcarare @MozLando @BranescuMihai @ValentinTimisica @ekager